Skip to content

HDDS-13079. Improve logging in DN for delete operation. #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryangupta1998 merged 1 commit into from
May 20, 2025
Merged

HDDS-13079. Improve logging in DN for delete operation. #8489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ private void processCmd(DeleteCmdInfo cmd) {
// Send ACK back to SCM as long as meta updated
// TODO Or we should wait until the blocks are actually deleted?
if (!containerBlocks.isEmpty()) {
LOG.debug("Sending following block deletion ACK to SCM");
int successCount = 0, failedCount = 0;

for (DeleteBlockTransactionResult result : blockDeletionACK.getResultsList()) {
boolean success = result.getSuccess();
Expand All @@ -392,11 +392,15 @@ private void processCmd(DeleteCmdInfo cmd) {
}

if (success) {
++successCount;
blockDeleteMetrics.incrProcessedTransactionSuccessCount(1);
} else {
++failedCount;
blockDeleteMetrics.incrProcessedTransactionFailCount(1);
}
}
LOG.info("Sending deletion ACK to SCM, successTransactionCount = {}," +
"failedTransactionCount= {}", successCount, failedCount);
}
cmdExecuted = true;
} finally {
Expand Down Expand Up @@ -648,7 +652,7 @@ public static boolean isDuplicateTransaction(long containerId, KeyValueContainer
if (metrics != null) {
metrics.incOutOfOrderDeleteBlockTransactionCount();
}
LOG.info(String.format("Delete blocks for containerId: %d"
LOG.debug(String.format("Delete blocks for containerId: %d"
+ " is received out of order, %d < %d", containerId, delTX.getTxID(),
containerData.getDeleteTransactionId()));
} else if (delTX.getTxID() == containerData.getDeleteTransactionId()) {
Expand Down