HDDS-12622. Reuse MinFreeSpaceCalculator instance in AvailableSpaceFilter#8118
Closed
peterxcli wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Member
Author
|
This would have conflict with #8090 |
Contributor
|
Thanks a lot @peterxcli for the patch. On second thought, seeing all the changes required to just pass the instance from |
Contributor
|
@peterxcli: #8119, please review when you have time |
Contributor
|
Thanks again @peterxcli for the patch, and sorry for changing direction after creating the Jira issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AvailableSpaceFilter currently creates a new MinFreeSpaceCalculator for each call. It should be reused, by passing the instance created by HddsDispatcher.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12622
How was this patch tested?
CI:
https://github.com/peterxcli/ozone/actions/runs/13960870751