Skip to content

HDDS-12330. Convert Volume, Bucket and Key count to use comma separated numbers #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArafatKhan2198 merged 3 commits into from
Feb 18, 2025
Merged

HDDS-12330. Convert Volume, Bucket and Key count to use comma separated numbers #7881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bed5bd7
HDDS-12330. Convert Volume, Bucket and Key count to the nearest word
spacemonkd Feb 14, 2025
aa482c7
Changed to comma conversion for number
spacemonkd Feb 14, 2025
927de99
Remove unused import
spacemonkd Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/common.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,16 @@ export const byteToSize = (bytes: number, decimals: number) => {
return isNaN(i) ? `Not Defined` : `${Number.parseFloat((bytes / (k ** i)).toFixed(dm))} ${sizes[i]}`;
};

/**
* The function transforms the provided number to a comma separated value
* Ex: 1000 will be 1,000
* @param num The number to convert
* @returns The number separated at every thousandth place by commas
*/
export function numberWithCommas(num: number) {
return num.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
}

export const nullAwareLocaleCompare = (a: string, b: string) => {
if (!a && !b) {
return 0;
Expand Down
3 changes: 2 additions & 1 deletion ...urces/webapps/recon/ozone-recon-web/src/v2/components/overviewCard/overviewSimpleCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
InboxOutlined,
QuestionCircleOutlined
} from '@ant-design/icons';
import { numberWithCommas } from '@/utils/common';


// ------------- Types -------------- //
Expand Down Expand Up @@ -138,7 +139,7 @@ const OverviewSimpleCard: React.FC<OverviewCardProps> = ({
<IconSelector iconType={icon} style={iconStyle} />
</Col>
<Col style={dataColStyle}>
{data}
{numberWithCommas(data)}
</Col>
</Row>
</Card>
Expand Down