Skip to content

HDDS-11408. Snapshot rename table entries are propagated incorrectly on snapshot deletes#7200

Merged
swamirishi merged 38 commits intoapache:masterfrom
swamirishi:HDDS-11408
Sep 20, 2024
Merged

HDDS-11408. Snapshot rename table entries are propagated incorrectly on snapshot deletes#7200
swamirishi merged 38 commits intoapache:masterfrom
swamirishi:HDDS-11408

Conversation

@swamirishi
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

On snapshot deletes, not all rename table entries are propogated to the next snapshot. This could lead to an incorrect reclamation of blocks on certain edge case scenarios.

Snapshot deletion steps:

  1. Has the snapshot been flushed to disk
  2. If next snapshot is not in deleted state
  3. If the next snapshot is AOS, then check key deletion service is not running
  4. Move all renameTableEntries/deleted/deletedDirectoryTable keys to next snapshot/AOS
  5. Check all tables empty
  6. Purge snapshot from the chain.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11408

How was this patch tested?

Adding unit tests

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants