HDDS-10653. Support custom metadata for MPU key

[ivandika3]

What changes were proposed in this pull request?

HDDS-6440 added support for custom metadata for normal object creation.

We should also support custom metadata creation for multipart upload key.

The metadata should be set during the multipart upload initiation request, which will be committed during the multipart upload complete request.

See: https://docs.aws.amazon.com/cli/latest/reference/s3api/create-multipart-upload.html

Should be tested using unit tests and acceptance tests.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10653

How was this patch tested?

Unit, integration, and acceptance tests.

Clean CI: https://github.com/ivandika3/ozone/actions/runs/8581916553

[ivandika3]

@kerneltime @DaveTeng0 @SaketaChalamchala @vtutrinov Could you help take a look when you have time?

[kerneltime]

cc @SaketaChalamchala @tanvipenumudy @vtutrinov can you'll please take a look?

[vtutrinov]

@ivandika3 thanks for the changes. LGTM at first glance, going to continue the review a little bit later

[adoroszlai]

Thanks @ivandika3 for the patch.

[adoroszlai]

nit: import from Mockito.

Suggested change

	import static org.mockito.ArgumentMatchers.anyMap;
	import static org.mockito.Mockito.any;
	import static org.mockito.Mockito.anyBoolean;
	import static org.mockito.Mockito.anyLong;
	import static org.mockito.Mockito.any;
	import static org.mockito.Mockito.anyBoolean;
	import static org.mockito.Mockito.anyLong;
	import static org.mockito.Mockito.anyMap;

[ivandika3]

Thank you for the review. Updated.

[adoroszlai]

Use assertThat instead of assertTrue for better message in case of failure. It also provides assertions for maps.

Suggested change

	for (Map.Entry<String, String> customEntry : customMetadata.entrySet()) {
	assertTrue(keyMetadata.containsKey(customEntry.getKey()));
	assertEquals(customEntry.getValue(), keyMetadata.get(customEntry.getKey()));
	}
	assertThat(keyMetadata).containsAllEntriesOf(customMetadata);

[ivandika3]

Thank you for the suggestion. Updated with assertThat (also updated for other similar tests).

I'll try to use more assertThat APIs in the future.

[ivandika3]

Some test failure due to the last commit, let me fix it first.

[ivandika3]

Fixed.

[vtutrinov]

@ivandika3 thanks for the patch, LGTM, +1

[adoroszlai]

Thanks @ivandika3 for updating the patch.

[adoroszlai]

Wouldn't keyToMultipartUpload.get(key) == null indicate "no such upload? We'd hit NPE in that case. I guess MultipartInfoStub#uploadID would rarely be null.

(createMultipartKey seems to have the correct logic.)

[ivandika3]

Thank you for catching it. I have updated it as the same logic as createMultipartKey.

[adoroszlai]

Thanks @ivandika3 for the patch, @vtutrinov for the review.

[ivandika3]

Thank you @vtutrinov and @adoroszlai for the reviews.