HDDS-5865. Make read retry interval and attempts in BlockInputStream configurable#6408
Merged
adoroszlai merged 25 commits intoapache:masterfrom Mar 21, 2024
Merged
Conversation
… modifies InputStream classes to access client configuration.
Contributor
Author
|
@adoroszlai and @ashishkumar50 can you please take a look |
adoroszlai
reviewed
Mar 20, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks a lot @SaketaChalamchala for updating the patch from #6309.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Mar 21, 2024
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Mar 21, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @SaketaChalamchala for updating the patch, LGTM. (Fixed a typo in the config description. Sorry I missed it earlier.)
adoroszlai
changed the title
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@SaketaChalamchala Thanks for updating the patch, LGTM.
Contributor
|
Thanks @SaketaChalamchala for the patch, @ashishkumar50 for the review. |
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…InputStream configurable (apache#6408) (cherry picked from commit c4dc6a0) Change-Id: I09e2ec572daf32755ffe17087c38416ec10574db
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…configurable (apache#6408) (cherry picked from commit c4dc6a0)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…configurable (apache#6408) (cherry picked from commit c4dc6a0)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…configurable (apache#6408) (cherry picked from commit c4dc6a0)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…configurable (apache#6408) (cherry picked from commit c4dc6a0)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…configurable (apache#6408) (cherry picked from commit c4dc6a0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Retry policy when reading keys is hardcoded. Made the read retry max attempts and retry interval configurable in client configuration ozone.client.max.read.retries and ozone.client.max.read.retries. Modified InputStream classes to accept client configuration so that read retry policy can be created wherever required.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5865
How was this patch tested?
Existing UT and integration tests should run as is.