HDDS-9922. Migrate TestOzoneFileInterfaces to JUnit5#5838
Merged
adoroszlai merged 2 commits intoapache:masterfrom Dec 22, 2023
Merged
HDDS-9922. Migrate TestOzoneFileInterfaces to JUnit5#5838adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
hemantk-12
approved these changes
Dec 22, 2023
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the patch.
Overall looks good to me. Left a minor comment which can be done as separate PR.
Also assumed the assertTrue(<string>.contains(...)) will be change to assertThat(<string>).contains(...) or assertThat(<exception>).hasMessage(...) in HDDS-9978 or some other jira as part of HDDS-9951.
...e/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractOzoneFileSystemTest.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks @hemantk-12 for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 1b26dd3)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 1b26dd3)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 1b26dd3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Merge
TestOzoneFileInterfacestest cases intoAbstractOzoneFileSystemTest. The latter is already on JUnit5, and is run with various parameters via subclasses.Tweaked assertions related to statistics to check increase in ops. count instead of assuming the stats are all 0 at the start of the test.
https://issues.apache.org/jira/browse/HDDS-9922
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7266811043