HDDS-7715. Implement a lightweight listStatus API#5275
Merged
kerneltime merged 6 commits intoapache:masterfrom Oct 27, 2023
Merged
HDDS-7715. Implement a lightweight listStatus API#5275kerneltime merged 6 commits intoapache:masterfrom
kerneltime merged 6 commits intoapache:masterfrom
Conversation
Contributor
|
@tanvipenumudy can you please update rebase this PR? |
40e7dbd to
ad176eb
Compare
Contributor
Author
|
Rebased the patch. @kerneltime, @duongkame, @adoroszlai could you please take a look at the changes? Thanks! |
adoroszlai
reviewed
Oct 17, 2023
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for the patch.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java
Outdated
Show resolved
Hide resolved
…ne/om/OzoneManager.java Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
adoroszlai
reviewed
Oct 18, 2023
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for updating the patch. I have one more question on second look.
...n/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @tanvipenumudy for iterating on the patch. I'm fine with the current version. Let's see if others have any comments. |
kerneltime
approved these changes
Oct 27, 2023
kerneltime
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To introduce a newer listStatus API (we have chosen to introduce a newer API over modifying the existing API as it would break compatibility for older ozone clients) which uses a trimmed
KeyInfo[BasicKeyInfo] proto message for excluding fields such asKeyLocationswhich are not very useful on the client side:The new lightweight listStatus API would be used for:
o3CLI: (ozone sh key list)The existing listStatus API will continue being used for:
ofscommandsThis patch shall utilize the server-side Ozone key encapsulations and proto messages introduced as part of HDDS-9079. Implement a lightweight listKeys API (PR #5115).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7715
How was this patch tested?