HDDS-2403: Remove leftover reference to OUTPUT_FILE from shellcheck.sh#149
Closed
snemuri wants to merge 1 commit intoapache:masterfrom
Closed
HDDS-2403: Remove leftover reference to OUTPUT_FILE from shellcheck.sh#149snemuri wants to merge 1 commit intoapache:masterfrom
snemuri wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
/retest |
adoroszlai
approved these changes
Nov 13, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks for the contribution @snemuri.
The fix works fine. Running hadoop-ozone/dev-support/checks/shellcheck.sh locally now only produces shellcheck warnings as expected, but not the No such file or directory error.
elek
approved these changes
Nov 13, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 works well.
Thanks the patch @snemuri and the review (+ report) @adoroszlai
Contributor
Author
|
Thanks for the review and commit @elek @adoroszlai |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…of directory (apache#7254) (apache#149) (cherry picked from commit d3b63c6) Co-authored-by: Sumit Agrawal <sumit.jecrc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed the leftover
OUTPUT_FILEfrom shellcheck.shWhat is the link to the Apache JIRA
HDDS-2403