HDDS-14938. Implement Iceberg's RewriteTablePath action with input validation#10053
HDDS-14938. Implement Iceberg's RewriteTablePath action with input validation#10053sreejasahithi wants to merge 3 commits intoapache:masterfrom
Conversation
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sreejasahithi for the patch.
...ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java
Outdated
Show resolved
Hide resolved
...ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java
Outdated
Show resolved
Hide resolved
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sreejasahithi for updating the patch.
...ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java
Outdated
Show resolved
Hide resolved
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sreejasahithi for updating the patch, LGTM.
ashishkumar50
left a comment
There was a problem hiding this comment.
@sreejasahithi Thanks for working on this, Can we put this into new module something like ozone-iceberg/tools instead of placing inside hadoop-ozone.
That would not fit existing build setup, why would we do that? |
Since this is specific just for iceberg ozone integration and not directly related to ozone module, so i was thinking not to put inside hadoop-ozone. If it doesn't fit in existing build setup then it is fine to put inside hadoop-ozone then. |
If we want to move the module outside hadoop-ozone then we would have to change the existing hadoop-ozone and root pom.xml and also add in 'hadoop-ozone/dist/src/main/assemblies/ozone-src.xml'. |
At least the following scripts would also need to be tweaked:
I don't see any reason to do increase the scope of this change with that. |
What changes were proposed in this pull request?
This patch implements Iceberg's RewriteTablePath action and validates the inputs provided for the path rewrite.
Prefix Rewrite Configuration
Allow specifying:
Optional startVersion and endVersion inputs.
Staging Location Handling
This change is required for upcoming patches in the epic: : HDDS-14937
What is the link to the Apache JIRA
HDDS-14938
How was this patch tested?
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/24018893628