HDDS-11820. Remove hard-coded principals from ozone-testkrb5#10
Merged
adoroszlai merged 1 commit intoapache:masterfrom Nov 29, 2024
Merged
HDDS-11820. Remove hard-coded principals from ozone-testkrb5#10adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
dombizita
approved these changes
Nov 28, 2024
Contributor
dombizita
left a comment
There was a problem hiding this comment.
Thanks for this improvement @adoroszlai! It'll be way easier this way. If others check this later, the corresponding Ozone side change is apache/ozone#7498, right?
Contributor
Author
|
Thanks @dombizita for the review.
That one is a pre-requisite for this, but another PR will follow after this image is available. In addition to updating the image, the only Ozone-side change will be: adoroszlai/ozone@bc23d0c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test user principals are currently defined in the
apache/ozone-docker-testkrb5repository. Whenever a new principal is needed for tests, we need to:init.shinapache/ozone-docker-testkrb5ozone-testkrb5image version inapache/ozoneapache/ozone(this steps is removed in HDDS-11810)This can be improved by creating principals just-in-time, right before exporting keytabs.
Benefits:
This PR removes hard-coded principals from the
ozone-testkrb5image.https://issues.apache.org/jira/browse/HDDS-11820
How was this patch tested?
Ran secure acceptance tests with this image and corresponding Ozone change:
https://github.com/adoroszlai/ozone/actions/runs/12067118583