ORC-1810: [C++] Add environment variable ORC_FORMAT_URL#2094
Closed
luffy-zh wants to merge 3 commits intoapache:mainfrom
Closed
ORC-1810: [C++] Add environment variable ORC_FORMAT_URL#2094luffy-zh wants to merge 3 commits intoapache:mainfrom
luffy-zh wants to merge 3 commits intoapache:mainfrom
Conversation
wgtmac
reviewed
Dec 25, 2024
| ExternalProject_Add (orc-format_ep | ||
| URL "https://www.apache.org/dyn/closer.lua/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz?action=download" | ||
| URL ${ORC_FORMAT_URL} | ||
| URL_HASH SHA256=739fae5ff94b1f812b413077280361045bf92e510ef04b34a610e23a945d8cd5 |
Member
There was a problem hiding this comment.
User provided URL may not match the URL_HASH below. We should probably avoid passing URL_HASH to ExternalProject_Add
| option(ORC_PREFER_STATIC_ZLIB "Prefer static zlib library, if available" ON) | ||
| option(ORC_PREFER_STATIC_GMOCK "Prefer static gmock library, if available" ON) | ||
|
|
||
| set(DEFAULT_ORC_FORMAT_URL "https://www.apache.org/dyn/closer.lua/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz?action=download") |
Member
There was a problem hiding this comment.
What about moving it to below line 139?
| option(ORC_PREFER_STATIC_GMOCK "Prefer static gmock library, if available" ON) | ||
|
|
||
| set(DEFAULT_ORC_FORMAT_URL "https://www.apache.org/dyn/closer.lua/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz?action=download") | ||
| set(ORC_FORMAT_URL ${DEFAULT_ORC_FORMAT_URL} CACHE STRING "URL from which to download ORC format library" FORCE) |
Member
There was a problem hiding this comment.
What about using environment variable?
if(DEFINED ENV{ORC_FORMAT_URL})
set(ORC_FORMAT_SOURCE_URL "$ENV{ORC_FORMAT_URL}")
else()
set(ORC_FORMAT_SOURCE_URL
"https://www.apache.org/dyn/closer.lua/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz?action=download"
)
endif()
dongjoon-hyun
requested changes
Dec 25, 2024
luffy-zh
changed the title
wgtmac
approved these changes
Dec 27, 2024
kou
approved these changes
Dec 29, 2024
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
Thanks!
FYI: Apache Arrow accepts not only source URL but also checksum. It's for accepting newer/older versions than pre-defined versions at https://github.com/apache/arrow/blob/main/cpp/thirdparty/versions.txt . Apache Arrow uses ExternalProject_Add()/FetchContent_Declare() for optional external libraries. But Apache ORC uses ExternalProject_Add() for mandatory orc-format dependency. So situations in Apache Arrow and Apache ORC may be different.
| option(ORC_PREFER_STATIC_ZSTD "Prefer static zstd library, if available" ON) | ||
| option(ORC_PREFER_STATIC_ZLIB "Prefer static zlib library, if available" ON) | ||
| option(ORC_PREFER_STATIC_GMOCK "Prefer static gmock library, if available" ON) | ||
|
|
Member
There was a problem hiding this comment.
We may want to revert this needless change.
dongjoon-hyun
approved these changes
Jan 3, 2025
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 16, 2025
### What changes were proposed in this pull request? Add an CMake option ORC_FORMAT_URL to indicate where to download the orc-format_ep ### Why are the changes needed? Handle the issue discussed apache/arrow#43417 ### How was this patch tested? Test it locally ### Was this patch authored or co-authored using generative AI tooling? NO Closes #2094 from luffy-zh/ORC-1810. Authored-by: luffy-zh <zhnice@outlook.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an CMake option ORC_FORMAT_URL to indicate where to download the orc-format_ep
Why are the changes needed?
Handle the issue discussed apache/arrow#43417
How was this patch tested?
Test it locally
Was this patch authored or co-authored using generative AI tooling?
NO