Skip to content

Round the completion item text width correctly #9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbien merged 1 commit into from
Nov 22, 2025
Merged

Round the completion item text width correctly #9032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ...editor.completion/src/org/netbeans/spi/editor/completion/support/CompletionUtilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,20 @@ private CompletionUtilities() {
* rendering area. It may be null which means no right text will be displayed.
* @return >=0 preferred rendering width of the item.
*/
public static int getPreferredWidth(String leftHtmlText, String rightHtmlText,
Graphics g, Font defaultFont) {
int width = BEFORE_ICON_GAP + ICON_WIDTH + AFTER_ICON_GAP + AFTER_RIGHT_TEXT_GAP;
if (leftHtmlText != null && leftHtmlText.length() > 0) {
width += (int)PatchedHtmlRenderer.renderHTML(leftHtmlText, g, 0, 0, Integer.MAX_VALUE, 0,
public static int getPreferredWidth(String leftHtmlText, String rightHtmlText, Graphics g, Font defaultFont) {
double width = BEFORE_ICON_GAP + ICON_WIDTH + AFTER_ICON_GAP + AFTER_RIGHT_TEXT_GAP;
if (leftHtmlText != null && !leftHtmlText.isEmpty()) {
width += PatchedHtmlRenderer.renderHTML(leftHtmlText, g, 0, 0, Integer.MAX_VALUE, 0,
defaultFont, Color.black, PatchedHtmlRenderer.STYLE_CLIP, false, true);
}
if (rightHtmlText != null && rightHtmlText.length() > 0) {
if (rightHtmlText != null && !rightHtmlText.isEmpty()) {
if (leftHtmlText != null) {
width += BEFORE_RIGHT_TEXT_GAP;
}
width += (int)PatchedHtmlRenderer.renderHTML(rightHtmlText, g, 0, 0, Integer.MAX_VALUE, 0,
width += PatchedHtmlRenderer.renderHTML(rightHtmlText, g, 0, 0, Integer.MAX_VALUE, 0,
defaultFont, Color.black, PatchedHtmlRenderer.STYLE_CLIP, false, true);
}
return width;
return (int) Math.ceil(width);
}

/**
Expand Down
Loading