Skip to content

Fixes find-usages and call-hierarchy on enum constructors. #8991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbien merged 1 commit into from
Nov 11, 2025
Merged

Fixes find-usages and call-hierarchy on enum constructors. #8991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions java/refactoring.java/src/org/netbeans/modules/refactoring/java/WhereUsedElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ public static WhereUsedElement create(CompilationInfo compiler, TreePath tree, b
return create(compiler, tree, null, inTest, inPlatform, inDependency, inImport);
}

@SuppressWarnings({"NestedAssignment", "AssignmentToMethodParameter"})
public static WhereUsedElement create(CompilationInfo compiler, TreePath tree, JavaWhereUsedFilters.ReadWrite access, boolean inTest, boolean inPlatform, boolean inDependency, AtomicBoolean inImport) {
CompilationUnitTree unit = tree.getCompilationUnit();
CharSequence content = compiler.getSnapshot().getText();
Expand Down Expand Up @@ -195,9 +196,7 @@ public static WhereUsedElement create(CompilationInfo compiler, TreePath tree, J
if (TreeUtilities.CLASS_TREE_KINDS.contains(t.getKind())) {
int[] pos = treeUtils.findNameSpan((ClassTree)t);
if (pos == null) {
Tree tr = tree.getParentPath().getLeaf();
if (tr instanceof NewClassTree) {
NewClassTree newClass = (NewClassTree) tr;
if (tree.getParentPath().getLeaf() instanceof NewClassTree newClass) {
start = (int) sp.getStartPosition(unit, newClass.getIdentifier());
end = (int) sp.getEndPosition(unit, newClass.getIdentifier());
} else {
Expand All @@ -207,7 +206,7 @@ public static WhereUsedElement create(CompilationInfo compiler, TreePath tree, J
start = end = (int) sp.getStartPosition(unit, t);
}
// #213723 hotfix, happens for enum values
if(start < 0) {
if(start < 0 || end < 0) {
TreePath parentPath = tree.getParentPath();
if(parentPath != null && (parentPath = parentPath.getParentPath()) != null
&& parentPath.getLeaf().getKind() == Tree.Kind.VARIABLE) {
Expand Down
Loading