Master Filesystem Valhalla compatibility

platform/masterfs/nbproject/project.properties

@@ -16,7 +16,7 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.8
+javac.release=17
 javadoc.arch=${basedir}/arch.xml
 javadoc.apichanges=${basedir}/apichanges.xml
 

platform/masterfs/src/org/netbeans/modules/masterfs/ExLocalFileSystem.java

@@ -60,6 +60,7 @@ public OneFileAttributeAttachedToRoot(
         }
 
 
+        @Override
         public String[] children(String f) {
             return super.children(f);
         }
@@ -69,6 +70,7 @@ public String[] children(String f) {
         * @param attrName name of the attribute
         * @return appropriate (serializable) value or <CODE>null</CODE> if the attribute is unset (or could not be properly restored for some reason)
         */
+        @Override
         public Object readAttribute(String name, String attrName) {
             return super.readAttribute(transformName (name), attrName);
         }
@@ -79,6 +81,7 @@ public Object readAttribute(String name, String attrName) {
         * @param value new value or <code>null</code> to clear the attribute. Must be serializable, although particular filesystems may or may not use serialization to store attribute values.
         * @exception IOException if the attribute cannot be set. If serialization is used to store it, this may in fact be a subclass such as {@link NotSerializableException}.
         */
+        @Override
         public void writeAttribute(String name, String attrName, Object value)
                 throws IOException {
             super.writeAttribute(transformName (name), attrName, value);
@@ -88,6 +91,7 @@ public void writeAttribute(String name, String attrName, Object value)
         * @param name the file
         * @return enumeration of keys (as strings)
         */
+        @Override
         public synchronized Enumeration<String> attributes(String name) {
             return super.attributes(transformName (name));
         }
@@ -97,6 +101,7 @@ public synchronized Enumeration<String> attributes(String name) {
         * @param oldName old name of the file
         * @param newName new name of the file
         */
+        @Override
         public synchronized void renameAttributes(String oldName, String newName) {
             super.renameAttributes(transformName (oldName), transformName (newName));
         }
@@ -105,22 +110,23 @@ public synchronized void renameAttributes(String oldName, String newName) {
         *
         * @param name name of the file
         */
+        @Override
         public synchronized void deleteAttributes(String name) {
             super.deleteAttributes(transformName (name));
         }
 
         private String transformName (String name) {
             char replaceChar = '|';//NOI18N       
             if (name.indexOf(replaceChar) != -1 ) {
-                StringBuffer transformed = new StringBuffer(name.length() + 50);
+                StringBuilder transformed = new StringBuilder(name.length() + 50);
                 for (int i = 0; i < name.length(); i++) {
                     transformed.append(name.charAt(i));                        
                     if (name.charAt(i) == replaceChar) 
                         transformed.append(replaceChar);                                                                    
                 }
                 name = transformed.toString();
             }
-            return name.replace('/',replaceChar);//NOI18N
+            return name.replace('/', replaceChar);//NOI18N
         }        
     }    
 }

platform/masterfs/src/org/netbeans/modules/masterfs/GlobalVisibilityQueryImpl.java

@@ -75,6 +75,7 @@ private static Preferences getPreferences() {
         return NbPreferences.root().node("/org/netbeans/core");
     }
 
+    @Override
     public boolean isVisible(FileObject file) {
         String name = file.getNameExt();
         if (isIgnoreHiddenInHome() && isHidden(name) && isInHomeFolder(file)) {
@@ -84,6 +85,7 @@ public boolean isVisible(FileObject file) {
         }
     }
 
+    @Override
     public boolean isVisible(File file) {
         String name = file.getName();
         if (isIgnoreHiddenInHome() && isHidden(name) && isInHomeFolder(file)) {
@@ -103,6 +105,7 @@ boolean isVisible(final String fileName) {
      * Add a listener to changes.
      * @param l a listener to add
      */
+    @Override
     public void addChangeListener(ChangeListener l) {
         cs.addChangeListener(l);
     }
@@ -111,6 +114,7 @@ public void addChangeListener(ChangeListener l) {
      * Stop listening to changes.
      * @param l a listener to remove
      */
+    @Override
     public void removeChangeListener(ChangeListener l) {
         cs.removeChangeListener(l);
     }

platform/masterfs/src/org/netbeans/modules/masterfs/MasterURLMapper.java

@@ -36,10 +36,12 @@ public final class MasterURLMapper extends URLMapper {
     public MasterURLMapper() {
     }
 
+    @Override
     public FileObject[] getFileObjects(final URL url) {                
         return delegate.getFileObjects(url);
     }
 
+    @Override
     public URL getURL(final FileObject fo, final int type) {
         return delegate.getURL(fo, type);
     }