Fix regression in MnemonicEditor#setValue#8787
Merged
Merged
Conversation
regression since 879f45f
mbien
added
Java
Member
Author
|
I think I remember what happened there, the PR wasn't meant to be merged that early since while updating the very last method in the patch, I thought that this would look much more straight forward with instanceof pattern chains (thats why i probably started removing the return statements). But bumping the module lang version didn't work, so I opened #8387 and didn't change it back. I must have forgotten about it and the PR got merged by accident most likely (#8385 (comment)) |
Member
Author
|
fix was tested at #8780 (comment), planning to merge it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression since #8385
fixes #8780