Repository navigation
TestSourceJarMojo forks to generate-sources instead of generate-test-sources #304
Description
TestSourceJarMojo.java:28 has @Execute(phase = "generate-sources"):
@Mojo(name = "test-jar", defaultPhase = "package")
@Execute(phase = "generate-sources")
public class TestSourceJarMojo extends TestSourceJarNoForkMojo {This is a test-jar goal but forks only to generate-sources, not generate-test-sources. If test sources are generated by another plugin in the generate-test-sources phase, they will not be available when the mojo runs, leading to an empty or incomplete test sources JAR.
Compare with TestSourceGeneratedJarMojo.java:28 which correctly uses generate-test-sources:
@Mojo(name = "generated-test-jar", defaultPhase = "package")
@Execute(phase = "generate-test-sources")
public class TestSourceGeneratedJarMojo extends TestSourceJarNoForkMojo {Fix: Change the phase to generate-test-sources.
Activity
kratos0718 commentedon Aug 5, 2026
I'd like to take this one.
Planning to change the fork phase to
generate-test-sourcesand extend thetest-jarIT to cover it. That IT currently only generates sources ingenerate-sources, so it passes either way — adding agenerate-test-sourcesexecution and asserting its output lands in the test-sources jar makes it fail on the current phase and pass after the change. That mirrors whattest-jar-generatedalready does for thegenerated-test-jargoal.elharo commentedon Aug 5, 2026
There's already a PR open on this.
kratos0718 commentedon Aug 6, 2026
Disregard my earlier note about taking this — I hadn't spotted #316 was already open. Closed my PR in favour of it.