[MINSTALL-194] Fail to install snapshot artifact when clean phase is used

[jira-importer]

Candice Tosi Michelon opened MINSTALL-194 and commented

{}After ugrading maven from version 3.6.3 to 3.9.4 a few maven projects started failing in the install phase with the error below{}: 

Failed to install artifact xxxxxx:jar:1.1-SNAPSHOT: xxxxx-1.1-SNAPSHOT.jar.3154215231322123456.tmp -> xxxxx-1.1-SNAPSHOT.jar -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) on project xxxxx: Failed to install artifact xxxxx:jar:1.1-SNAPSHOT: xxxxx-1.1-SNAPSHOT.jar

Caused by: org.apache.maven.plugin.MojoExecutionException:

Caused by: org.eclipse.aether.installation.InstallationException:

Caused by: java.nio.file.AccessDeniedException:

 

Command used: mvn clean install

 

All the projects affected have the following characteristics:

• Multi-modules
• The clean phase is used at least once
• The pmd check is performed
• A jar snapshot of the module already existis in the maven repository folder (.m2)

This is not a blocker issue because it is still possible to build the projects and install the snapshots in the local repository if the follwoing options are used:

• Option 1: Avoid using the clean phase. Use only 'mvn install'.
• Option 2: Use the following mvn commands:
  • mvn clean
  • mvn install -N
  • mvn install -rf <first module name to be built in the project>
• Option 3: Use the following commands:
  • mvn clean install (the build will fail trying to install the jar of one of the modules in the .m2 folder)
  • mvn install -rf <name of that first module that failed to have the jar installed>
• Option 4: skip pmd check:
  • mvn clean install -Dpmd.skip=true
• Option 5: delete the jar snapshots previously installed in the maven repository folder.

I can't provide a sample project or pom because I was not able to reproduce the issue in a new project. Also, there are other projects with the same characteristcs that does not present the problem, I could not identify any significant difference between them as dependencies and plugins versions, as well as build configuration, are mostly the same.

---

Affects: 3.1.1

Attachments:

• image-2023-11-16-08-15-07-597.png (10.78 kB)
• StackTrace.txt (12.44 kB)
• StackTraceDebug.txt (15.87 kB)

Issue Links:

• MRESOLVER-372 Sporadic AccessDeniedEx on Windows

[jira-importer]

Michael Osipov commented

Upgrade to 3.9.5 first.

[jira-importer]

Candice Tosi Michelon commented

Even after upgrading to 3.9.5 the problem still occurs. I updated the environment field with the maven version used in the last test I did.

[jira-importer]

Slawomir Jaranowski commented

Can you provide a full stack trace after executing mvn -e ....?

[jira-importer]

Slawomir Jaranowski commented

Even more outputs from mvn -X ... can also help - if possible please attach one.

[jira-importer]

Slawomir Jaranowski commented

Option 4: skip pmd check:
mvn clean install -Dpmd.skip=true

It is very interesting how pmd can impact on installed artifacts ...

[jira-importer]

Candice Tosi Michelon commented

Sure, I uploaded a txt file the full stack with -e.

[jira-importer]

Candice Tosi Michelon commented

I uploaded another file with -X option, but only the last part of the output, when install plugin starts. Please let me know if you need other parts of the output. 

[jira-importer]

Michael Osipov commented

Tamas Cservenak

[jira-importer]

Slawomir Jaranowski commented

Looks similar to MRESOLVER-372

[jira-importer]

Candice Tosi Michelon commented

This issue was fixed by removing the tag 'aggregate' from pmd plugin configuration. 

!image-2023-11-16-08-15-07-597.png!

This solution was based on  maven PMD plugin team's suggestion

Now all our builds are running smoothly again.

[jira-importer]

Tamas Cservenak commented

As I see (more like assume), what happens is that due PMD.aggregate=true, the plugin will "load all" (see Andreas explanation), and that simply put, keeps even project JAR files open, while again Maven itself tries to "install" these same files (into same place, as I guess we talk about snaphot project). And here, due MRESOLVER-372 "atomic move" Windows refuses to atomically replace the file...