Add tests for requireJavaVersion five-part JDK strings #980 - #1019
Merged
slawekjaranowski merged 1 commit intoAug 31, 2026
Merged
Conversation
normalizeJDKVersion(21.0.10.0.1) becomes 21.0.10-0, so a requireJavaVersion
pin of ${java.version} only passes when the raw runtime string is tried first.
Closed
Closed
slawekjaranowski
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).#980 asked for tests around #967.
requireJavaVersionwith${java.version}pins the raw runtime string. For21.0.10.0.1that normalizes to21.0.10-0, so the exact string has to be accepted first.I added:
normalizeJDKVersion("21.0.10.0.1")→21.0.10-021.0.10.0.1is allowedsetVersion(SystemUtils.JAVA_VERSION)thenexecute()still passes on the running JDKmvn -pl enforcer-rules -am verify -DskipITs -Dtest=TestRequireJavaVersionis green here.