Include transitive SNAPSHOT inputs in project checksums - #534
Open
goutamadwant wants to merge 10 commits into
Open
goutamadwant wants to merge 10 commits into
goutamadwant wants to merge 10 commits into
Conversation
Collect Maven's mediated dependency graph before cache lookup so a changed transitive SNAPSHOT invalidates cached bytecode even when its direct dependency's reproducible JAR is unchanged. Use project checksums for transitive reactor inputs and bypass cache restore and save when the graph cannot be resolved. Cover SNAPSHOT and release bridges, cache hits, exclusions, dependency management, reactor inputs, and offline early lifecycle builds with integration tests. Fixes apache#407
olamy
reviewed
Sep 15, 2026
|
|
||
| // Collect through Maven so dependency management, exclusions and scope mediation match the build. | ||
| // Resolve only additional external snapshots; reactor dependencies use project checksums. | ||
| DefaultDependencyResolutionRequest request = |
Member
There was a problem hiding this comment.
Well, now we are forcing full transitive graph collection + snapshot resolution during cache-key calculation, which could be avoided when you have cache hits, for cache hits where we were skipping dependency resolution.
On a large project, this will add unexpected potential latency
olamy
reviewed
Sep 15, 2026
| try { | ||
| inputInfo = projectInputCalculator.calculateInput(project); | ||
| } catch (DependencyGraphResolutionException e) { | ||
| LOGGER.warn("Skipping build cache for {}: {}", projectName, e.getMessage()); |
Member
There was a problem hiding this comment.
Well, if any remote repositories check for snapshots, we will now skip a module that has not been restored or saved. Caching is becoming subject to remote repo availability; this sounds fragile to me.
olamy
reviewed
Sep 15, 2026
| // Resolve only additional external snapshots; reactor dependencies use project checksums. | ||
| DefaultDependencyResolutionRequest request = | ||
| new DefaultDependencyResolutionRequest(project, session.getRepositorySession()); | ||
| request.setResolutionFilter((node, parents) -> { |
Member
There was a problem hiding this comment.
there should be filtering here. for main source we do not need to check test scope dependencies. Any change in test dependencies will invalidate the cache for src/main
…snapshot-checksums
Signed-off-by: goutamadwant <workwithgoutam@gmail.com>
Signed-off-by: goutamadwant <workwithgoutam@gmail.com>
Signed-off-by: goutamadwant <workwithgoutam@gmail.com>
Signed-off-by: goutamadwant <workwithgoutam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.
For
app -> bridge -> leaf-SNAPSHOT, changingleafcan leave the reproduciblebridgeJAR byte-identical. The application checksum currently includes only declared mutable dependencies, so a clean application build can restore stale compiled constants from cache.Collect Maven's mediated dependency graph before cache lookup and hash additional external SNAPSHOT artifacts. Use project checksums for transitive reactor inputs. If graph resolution is unavailable, skip cache restoration and saving, then let normal Maven execution enforce dependency requirements.
The integration tests cover SNAPSHOT and release bridges, unchanged-input cache hits, exclusions, dependency management, transitive reactor inputs, and offline
validate. Both bridge cases fail on unchanged master (8bec537); their fixed cached outputs match uncached rebuilds. Graph collection happens before lookup; only additional external SNAPSHOT artifacts are resolved.Validation on JDK 17:
mvn -Prun-its verify javadoc:jar: passed with Maven 3.9.16. The run reported 97 unit tests and 354 integration tests, with zero failures or errors. Four schema-dependent unit tests and one macOS permission test were skipped.mvn -Prun-its,maven3.10 -Dtest='MavenProjectInput*' -Dit.test=TransitiveSnapshotTest verify: passed with Maven 3.10.0-rc-1 for the integration builds.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
This change uses integration tests against Maven's real dependency resolver.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.