Skip to content

fix(desktop): resolve login-shell PATH at Electron startup #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 6 commits into from
Jul 25, 2026
Merged

fix(desktop): resolve login-shell PATH at Electron startup #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea3faed
fix(desktop): resolve login-shell environment at Electron startup
Jul 22, 2026
84771a6
fix(desktop): allow-list shell-env.ts console diagnostics in check-co…
Jul 22, 2026
2b5ddb0
fix(desktop): contain shell probe environment
Astro-Han Jul 25, 2026
2ab43fb
fix(desktop): import only login shell PATH
Astro-Han Jul 25, 2026
f7a8a57
docs(desktop): align shell PATH comments
Astro-Han Jul 25, 2026
5856845
fix(desktop): contain shell probe descendants
Astro-Han Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/desktop/e2e/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ function buildE2eEnv(
}
}
env.MAKA_E2E = '1';
// The login-shell PATH probe must not make E2E command resolution depend on
// the developer or CI account. buildE2eEnv owns the launched environment,
// so it owns the deterministic skip flag (unlike relying on TERM, which is
// unset under xvfb).
env.MAKA_SKIP_SHELL_ENV = '1';
env.MAKA_E2E_USER_DATA_DIR = userDataDir;
if (e2eFixtureScenario) env.MAKA_E2E_FIXTURE = e2eFixtureScenario;
if (locale) env.MAKA_E2E_FIXTURE_LOCALE = locale;
Expand Down
Loading
Loading