perf(test): reduce redundant CLI subprocess startup #2387

Activity

1. Astro-Han

   added

   enhancementNew feature or requestNew feature or request

   on Aug 7, 2026
2. Astro-Han

   added a parent issue on Aug 7, 2026

   • perf(test): remove redundant work from expensive tests #2382
3. UncertaintyDeterminesYou4ndMe commented on Aug 8, 2026

   

   UncertaintyDeterminesYou4ndMe

   on Aug 8, 2026

   Contributor

   More actions

   I'll take this one, continuing from the #2389 series.

   Plan per the issue outcome list:

   1. Inventory every test that spawns a Node subprocess across CLI, Headless CLI, and harness A/B CLI suites, and classify each as (a) exercising a genuine process-level contract — stdin wiring, stdout/stderr framing, exit codes, signals, persistence across process death, detached execution, fail-closed — or (b) exercising ordinary command semantics that an existing in-process entry point already covers.
   2. Move class (b) scenarios in process; keep representative subprocess coverage for every class (a) contract and name the retained contracts in the PR.
   3. Separate PRs for CLI and Headless, each with comparable before/after timing.

   No production command behavior changes.
4. UncertaintyDeterminesYou4ndMe commented on Aug 8, 2026

   

   UncertaintyDeterminesYou4ndMe

   on Aug 8, 2026

   Contributor

   More actions

   Both workspace PRs are up:

   • test(cli): run ordinary run-command semantics in process #2476 — CLI: run-command.test.ts ordinary semantics through the injectable MakaRunDeps seam. 15.06s → 3.60s (−76%), spawns 29 → 6. Retained: piped stdin ×3, SIGINT → 130 ×2, fail-closed sandbox boundary ×1.
   • test(headless): run ordinary CLI command semantics in process #2479 — Headless: cli.test.ts / contamination-scan-cli.test.ts / harness-ab-cli.test.ts through the exported routers (runMakaEvalCli, scan main(argv), launcher main()). 30.65s → 19.61s (−36%), spawns 43 → 9. Retained: bin wiring, executable footer + realpath guard, detached launcher / crash journal / credential-order contracts.

   Surveyed and deliberately left alone: runtime-bootstrap.test.ts and the pi-tui-runner signal probes (real process lifecycle is the subject), pi-cli-json-transport.test.ts (already fake-child DI), runtime-policy-ab-cli.test.ts (single test is the representative subprocess; its main() is unexported and a 0.6s saving does not justify the production touch).

   No production command behavior changes in either PR.
5. UncertaintyDeterminesYou4ndMe

   added 3 commits that reference this issue on Aug 8, 2026

   test(headless): run ordinary CLI command semantics in process

   ...

   6bfc7b3

   test(headless): run ordinary CLI command semantics in process

   ...

   e424d56

   test(cli): run ordinary run-command semantics in process

   ...

   e335ba3
6. Astro-Han

   added a commit that references this issue on Aug 8, 2026

   test(headless): run ordinary CLI command semantics in process (#2480)

   ...

   56ddb9f
7. YayoiNanoka

   closed this as completedon Aug 17, 2026