fix(skill-and-tool-validator): harden three non-blocking review leftovers - #970
Merged
justinmclean merged 2 commits intoJul 27, 2026
Merged
Conversation
…vers Correct the license-size docstring to bytes, skip the live header integration out-of-tree instead of aborting, and catch OSError from validate_eval_coverage directory listing the same way collect_tool_python_files does. Also re-lock root uv.lock mypy requires-dev specifiers to >=2.3.0 so prek stops rewriting the lock when this tool is touched (same correction as apache#965). Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
justinmclean
approved these changes
Jul 27, 2026
justinmclean
left a comment
Member
There was a problem hiding this comment.
Solid. I checked the skipif first, since evaluating a helper in a decorator can break collection rather than skip if it raises: find_repo_root returns CWD when it finds no skills/, so out-of-tree the helper returns None and the test skips cleanly. Good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_tool_python_filesdocstring (and size-threshold comment) so it says bytes, matchingpath.stat().st_size.skipifwhen the checkout is not a full magpie tree; add a unit test that proves the skip condition fires out-of-tree.OSErrorfromvalidate_eval_coverage'siterdir()calls (skills/ and evals/) the same waycollect_tool_python_filesdoes, so a restrictive runner gets a quiet skip instead of an unhandledPermissionError.uv.lockmypyrequires-devspecifiers to>=2.3.0soprekstops rewriting the lock when this tool is touched (same correction as build(deps-dev): re-lock uv.lock against the mypy>=2.3.0 dev pins #965 — drop that hunk if build(deps-dev): re-lock uv.lock against the mypy>=2.3.0 dev pins #965 lands first).Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
uv run --directory tools/skill-and-tool-validator --group dev pytest— all passedPermissionErrorcasesprekcommit hooks pass on changed files (ruff/mypy/ workspacepytest/skill-and-tool-validate)Signed-off-by)RFC-AI-0004 compliance
Linked issues
Closes #941