Skip to content

fix(skill-evals): remove Tier-B exclusivity qualifier from stage-2 fixture - #962

Merged
justinmclean merged 1 commit into
apache:mainfrom
HeaTTap:fix/remove-tier-b-exclusivity-qualifier-fixture
Jul 27, 2026
Merged

fix(skill-evals): remove Tier-B exclusivity qualifier from stage-2 fixture#962
justinmclean merged 1 commit into
apache:mainfrom
HeaTTap:fix/remove-tier-b-exclusivity-qualifier-fixture

Conversation

@HeaTTap

@HeaTTap HeaTTap commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #950

Removed the redundant "only" qualifier from the Tier B definition in tools/skill-evals/evals/pr-management-quick-merge/stage-2-triviality/fixtures/system-prompt.md to match candidate-rules.md.

@justinmclean justinmclean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and it matches candidate-rules.md:140 word for word now. I checked all eight stage-2 cases and none of them can tell the two wordings apart, so no expected output moves, exactly as the issue predicted. Good call leaving the second only at line 80 alone, that one mirrors candidate-rules.md:144 and is not the same defect.

Note that it was not clear to me if you ran the eval tests or not; please run the tests to confirm that any changes do not introduce errors before you raise a PR.

@justinmclean
justinmclean merged commit 2aa6c04 into apache:main Jul 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the Tier-B exclusivity qualifier from the quick-merge stage-2 fixture

2 participants