Skip to content

Update privacy-llm-gate.md: branch-name confidentiality validation has shipped #933

Description

@justinmclean

Summary

Rewrite the Known gaps bullet in tools/spec-loop/specs/privacy-llm-gate.md
that says branch-name confidentiality validation is missing. The check exists.

Background

The bullet reads "Branch-name confidentiality validation is missing... no
deterministic check scans skill/docs examples for CVE IDs or embargoed terms in
generated branch names." That check shipped: validate_branch_name_confidentiality
is defined in the validator and called twice, once over skill files and once over
docs/.

Spec Known gaps sections are not just documentation: the spec-loop plan beat
reads them to choose the next work item, so a gap that describes already-shipped
code sends the loop at finished work.

Where to look

  • tools/spec-loop/specs/privacy-llm-gate.md line 93 - the bullet to rewrite.
  • tools/skill-and-tool-validator/src/skill_and_tool_validator/__init__.py -
    validate_branch_name_confidentiality is called at lines 3690 and 3745. Read
    what it actually asserts before describing it.

Verify by finding the call site, not the definition. A function can be
defined and never wired in, in which case the gap would still be open. The two
call sites above are the evidence that it runs.

Acceptance criteria

  • The bullet describes the shipped check instead of claiming it is missing.
  • The description matches what the code checks (which terms, which file
    trees, and that it is a SOFT advisory).
  • uv run --project tools/spec-validator spec-validate tools/spec-loop/specs/
    passes.

Estimated effort

~ 30 minutes for someone new to the codebase, mostly reading the check to describe it
accurately.

Getting started

New to Magpie? Start with
Your first contribution.

Note: this issue was drafted by an AI-assisted mentoring tool and may contain
mistakes. A Magpie maintainer, a real person, will be the next to engage on it.
If something here looks wrong or unclear, please say so on the issue and a
maintainer will follow up. See
CONTRIBUTING.md
for how Magpie handles contributions.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions