KAFKA-20091: Fix inconsistency in time-based retention checks between remote and local segment deletion logic. #21352
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When currentTime- largestTimestamp of segment = retentionMs, the behavior is different:
cc @kamalcph
Thanks for your comments on KIP-1241 .
While I thinking through one of the your comments and reading the code, I noticed a potential problem in this area, so I opened this PR. Many thanks.