Skip to content

[remove datanode] Fix ArrayIndexOutOfBoundsException in computeInitialDbLoad #15718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HxpSerein merged 2 commits into from
Jun 17, 2025
Merged

[remove datanode] Fix ArrayIndexOutOfBoundsException in computeInitialDbLoad #15718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9edc503
fix array out of bound
HxpSerein Jun 16, 2025
ac89802
enhance UT
HxpSerein Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public Map<TConsensusGroupId, TDataNodeConfiguration> removeNodeReplicaSelect(
// 1. prepare: compute regionCounter, databaseRegionCounter, and combinationCounter

prepare(availableDataNodeMap, allocatedRegionGroups, Collections.emptyList());
computeInitialDbLoad(databaseAllocatedRegionGroupMap);
computeInitialDbLoad(availableDataNodeMap, databaseAllocatedRegionGroupMap);

// 2. Build allowed candidate set for each region that needs to be migrated.
// For each region in remainReplicasMap, the candidate destination nodes are all nodes in
Expand Down Expand Up @@ -432,9 +432,11 @@ private int[] getCurrentMetrics(
/**
* Compute the initial load for each database on each data node.
*
* @param availableDataNodeMap currently available DataNodes, ensure size() >= replicationFactor
* @param databaseAllocatedRegionGroupMap Mapping of each database to its list of replica sets.
*/
private void computeInitialDbLoad(
Map<Integer, TDataNodeConfiguration> availableDataNodeMap,
Map<String, List<TRegionReplicaSet>> databaseAllocatedRegionGroupMap) {
initialDbLoad = new HashMap<>();

Expand All @@ -446,7 +448,9 @@ private void computeInitialDbLoad(
for (TRegionReplicaSet replicaSet : replicaSets) {
for (TDataNodeLocation location : replicaSet.getDataNodeLocations()) {
int nodeId = location.getDataNodeId();
load[nodeId]++;
if (availableDataNodeMap.containsKey(nodeId)) {
load[nodeId]++;
}
}
}
initialDbLoad.put(database, load);
Expand Down
11 changes: 8 additions & 3 deletions ...tdb/confignode/manager/load/balancer/region/GreedyCopySetRemoveNodeReplicaSelectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,20 @@ public void testSelectDestNode() {
DATA_REGION_PER_DATA_NODE * TEST_DATA_NODE_NUM / DATA_REPLICATION_FACTOR;

List<TRegionReplicaSet> allocateResult = new ArrayList<>();
List<TRegionReplicaSet> databaseAllocateResult = new ArrayList<>();
for (int index = 0; index < dataRegionGroupNum; index++) {
allocateResult.add(
TRegionReplicaSet replicaSet =
GCR_ALLOCATOR.generateOptimalRegionReplicasDistribution(
AVAILABLE_DATA_NODE_MAP,
FREE_SPACE_MAP,
allocateResult,
allocateResult,
DATA_REPLICATION_FACTOR,
new TConsensusGroupId(TConsensusGroupType.DataRegion, index)));
new TConsensusGroupId(TConsensusGroupType.DataRegion, index));
TRegionReplicaSet replicaSetCopy = new TRegionReplicaSet(replicaSet);

allocateResult.add(replicaSet);
databaseAllocateResult.add(replicaSetCopy);
}

List<TRegionReplicaSet> migratedReplicas =
Expand Down Expand Up @@ -158,7 +163,7 @@ public void testSelectDestNode() {
}
Map<TConsensusGroupId, TRegionReplicaSet> remainReplicasMap = new HashMap<>();
Map<String, List<TRegionReplicaSet>> databaseAllocatedRegionGroupMap = new HashMap<>();
databaseAllocatedRegionGroupMap.put("database", allocateResult);
databaseAllocatedRegionGroupMap.put("database", databaseAllocateResult);

for (TRegionReplicaSet remainReplicaSet : remainReplicas) {
remainReplicasMap.put(remainReplicaSet.getRegionId(), remainReplicaSet);
Expand Down
Loading