Add some supplementary logs during partition allocation#15234
Merged
OneSizeFitsQuorum merged 4 commits intomasterfrom Mar 31, 2025
Merged
Add some supplementary logs during partition allocation#15234OneSizeFitsQuorum merged 4 commits intomasterfrom
OneSizeFitsQuorum merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds supplementary logging and database existence checks to help diagnose partition allocation issues, particularly when the corresponding database is logically deleted.
- Updated logging in DeleteDatabaseProcedure to include the database name.
- Added database existence checks with error messages in getOrCreateSchemaPartition and getOrCreateDataPartition methods.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DeleteDatabaseProcedure.java | Updated log message to be more descriptive with the database name. |
| PartitionManager.java | Introduced database existence checks and refined error messages for both schema and data partition allocations. |
...confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
Outdated
Show resolved
Hide resolved
...confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
Outdated
Show resolved
Hide resolved
…e/manager/partition/PartitionManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e/manager/partition/PartitionManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15234 +/- ##
============================================
+ Coverage 39.35% 39.41% +0.06%
Complexity 193 193
============================================
Files 4596 4624 +28
Lines 295656 297771 +2115
Branches 36847 37171 +324
============================================
+ Hits 116343 117362 +1019
- Misses 179313 180409 +1096 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackieTien97
pushed a commit
that referenced
this pull request
Apr 14, 2025
* finished * add database not exists exception * Update iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit b6fea63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process of creating partitions might throw some NPEs when the corresponding database is deleted logically. Thus, we add some logs for clearing the bug suspicion.