Unifying Exception Messages for Aggregation Functions#15231
Merged
Beyyes merged 3 commits intoapache:masterfrom Apr 1, 2025
Merged
Unifying Exception Messages for Aggregation Functions#15231Beyyes merged 3 commits intoapache:masterfrom
Beyyes merged 3 commits intoapache:masterfrom
Conversation
FearfulTomcat27
force-pushed
the
fix/aggregateErrorMessage
branch
from
2ca929d to
17ac342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update the error messages in various accumulator classes to use more specific aggregation names. The changes ensure that the error messages accurately reflect the aggregation type being processed.
Updates to error messages in accumulator classes:
CountAllAccumulator.java: Updated error message to specify "CountAll" instead of "Count".FirstByAccumulator.java: Updated error message to specify "FirstBy" instead of "First".LastByAccumulator.java: Updated error message to specify "LastBy" instead of "Last".MaxAccumulator.java: Updated error messages to specify "Max Aggregation" instead of "LastValue" or "Last". [1] [2]MinAccumulator.java: Updated error messages to specify "Min Aggregation" instead of "LastValue" or "Last". [1] [2]SumAccumulator.java: Updated error messages to specify "Sum Aggregation" instead of "aggregation Sum". [1] [2]TableVarianceAccumulator.java: Updated error messages to specify "Variance Aggregation" instead of "aggregation variance". [1] [2]GroupedAvgAccumulator.java: Updated error message to specify "AVG Aggregation" instead of "aggregation AVG".GroupedExtremeAccumulator.java: Updated error messages to specify "Extreme Aggregation" instead of generic "Unsupported data type". [1] [2] [3] [4] [5] [6] [7] [8]GroupedFirstAccumulator.java: Updated error messages to specify "First Aggregation" instead of generic "Unsupported data type". [1] [2] [3] [4] [5] [6] [7] [8]GroupedFirstByAccumulator.java: Updated error messages to specify "FirstBy Aggregation" instead of generic "Unsupported data type". [1] [2] [3]