Pipe: Added userName / password logic for alter pipe replace statement#15219
Merged
SteveYurongSu merged 2 commits intoapache:masterfrom Mar 28, 2025
Merged
Pipe: Added userName / password logic for alter pipe replace statement#15219SteveYurongSu merged 2 commits intoapache:masterfrom
SteveYurongSu merged 2 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds logic to incorporate user authentication into the alter pipe replace statement by enriching source and connector attributes with the current user's name. The key changes include refactoring the loop variable names for clarity, extracting the userName from the session in both TreeConfigTaskVisitor and TableConfigTaskVisitor, and invoking dedicated methods to check and enrich user-related attributes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/TreeConfigTaskVisitor.java | Refactored extractor attribute loop and added userName extraction along with enrichment of source and connector attributes. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/TableConfigTaskVisitor.java | Added final qualifiers to parameters and variables, enforced admin check using userName, and applied similar enrichment logic as in TreeConfigTaskVisitor. |
SteveYurongSu
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR