Load: Support multi-disks awareness for IoTV2 and Pipe#15181
Merged
OneSizeFitsQuorum merged 15 commits intoapache:masterfrom Mar 27, 2025
Merged
Load: Support multi-disks awareness for IoTV2 and Pipe#15181OneSizeFitsQuorum merged 15 commits intoapache:masterfrom
OneSizeFitsQuorum merged 15 commits intoapache:masterfrom
Conversation
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/PathUtils.java
Outdated
Show resolved
Hide resolved
SteveYurongSu
requested changes
Mar 26, 2025
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
Outdated
Show resolved
Hide resolved
SteveYurongSu
requested changes
Mar 27, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
...re/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/disk/ILoadDiskSelector.java
Outdated
Show resolved
Hide resolved
SteveYurongSu
approved these changes
Mar 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multi-disks awareness for load operations by adding different disk selection strategies for both ordinary load and Pipe/IoTV2 load. It adds a new MinIOSelector implementation, integrates disk selector configuration into IoTDBConfig and IoTDBDescriptor, and updates DataRegion to choose between selectors based on file origin.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/disk/MinIOSelector.java | New disk selector implementation using MinIO strategy. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/disk/InheritSystemMultiDisksStrategySelector.java | Base implementation for a multi-disks selection strategy. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/disk/ILoadDiskSelector.java | Added interface for load disk selectors along with a new enum option. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java | Updated to initialize and use different disk selectors based on file origin. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java | Updated to load disk selector configurations and adjust consensus configuration. |
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java | Added new configuration properties for disk selector strategies. |
Files not reviewed (1)
- iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: Language not supported
Comments suppressed due to low confidence (1)
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/disk/MinIOSelector.java:50
- [nitpick] Consider renaming the lambda parameter 'v' to a more descriptive name (e.g., 'dataDir') to improve code readability.
.map(v -> fsFactory.getFile(v, IoTDBConstant.UNSEQUENCE_FOLDER_NAME).getPath())
SteveYurongSu
approved these changes
Mar 27, 2025
Pengzna
added a commit
to Pengzna/iotdb
that referenced
this pull request
Mar 27, 2025
(cherry picked from commit a81c5c6)
OneSizeFitsQuorum
pushed a commit
that referenced
this pull request
Mar 27, 2025
JackieTien97
pushed a commit
that referenced
this pull request
Apr 14, 2025
* multi-disk aware * get mount point * enhance log * fix up * fix up * fix import * add test code * use file store * add strategy for load disk selector * fix description * fix review * fix default * spotless * fix review * adopt to multi-layer storage (cherry picked from commit a81c5c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title.
Usage of
FileStoreto get disk root of one specific file has been self tested.Test on MacOS Machine:
Test on Linux Machine: