Repository navigation
Docs: Clarify Spark branch write precedence over WAP branch - #18409
Closed
kastoestoramadus wants to merge 2 commits into
Closed
kastoestoramadus wants to merge 2 commits into
kastoestoramadus wants to merge 2 commits into
Conversation
Branch resolution no longer matched SparkTableUtil after apache#15288: in Spark 4.1 and higher an explicit branch from the table identifier or the `branch` write option takes priority over the session WAP branch, while Spark 3.5 and 4.0 reject an explicit branch combined with a WAP branch. Document the precedence, the write option, and which branches may be created during a write.
kastoestoramadus
marked this pull request as ready for review
October 7, 2026 10:34
… option The WAP ID/branch exclusivity is validated when the WAP branch is actually used, the branch write option requires the Iceberg extensions unless the identifier names a branch, and on 3.5/4.0 spark.wap.branch is ignored on tables without WAP enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15916
After #15288 the "Writing to Branches" section of
docs/docs/spark-writes.mdno longer matchedSparkTableUtil.determineWriteBranch.Before: the page said the target branch must always exist, and that a branch identifier and
spark.wap.branch"cannot both be specified".After:
branchwrite option (must match the identifier branch if both are set), and that an explicit branch wins over the session WAP branch, which is used only when none is set and WAP is enabled.spark.wap.branchstill fails validation.branchoption (4.1+) may create it during the write.Docs only, no test to write.
cd site && make build(markdown lint +mkdocs build) passes.Generated with deepseek-4.1-flash/h through Claude Code
Reviewed by sonnet-5.5/l