Repository navigation
Docs: Remove spec changes from Java release notes - #18379
Conversation
|
Alternative for #18379 Here is how it looks like: |
nssalian
left a comment
There was a problem hiding this comment.
Thank you for adding this!
| * OpenAPI | ||
| - Add RemovePartitionSpecsUpdate REST update type ([\#10846](https://github.com/apache/iceberg/pull/10846)) | ||
| - Add endpoint to retrieve valid credentials for a given table ([\#11281](https://github.com/apache/iceberg/pull/11281)) | ||
| - Standardize credentials in loadTable/loadView responses ([\#10722](https://github.com/apache/iceberg/pull/10722)) | ||
| - Add Scan Planning Endpoints to open api spec ([\#9695](https://github.com/apache/iceberg/pull/9695)) | ||
| - Add REST Compatibility Kit ([\#10908](https://github.com/apache/iceberg/pull/10908)) |
There was a problem hiding this comment.
This doesn't look quite right. Still Open API, but what are we tracking here?
There was a problem hiding this comment.
I kept this here as the REST Compatibility Kit is released along with the java release.
Do I miss something?
|
This looks better than the other approach! |
Spec changes are adopted by community vote and are independent of the Java releases, so listing them in the Java release notes is misleading. Each spec now starts with a version table that shows the status, adoption date and adoption vote of every version. Specs with changes after adoption end with a chapter that lists each voted change with its vote, pull request and vote close date. The REST Catalog spec page gets the same treatment. The Releases menu links to the version table of each spec, and spec entries are removed from the Java release notes. Generated-by: GitHub Copilot CLI (Claude Opus 5.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the spec-only entries that were still listed in older Java releases: the AES GCM stream spec and the Puffin spec snapshot ID update in 1.2.0, the Puffin spec pull request in 0.14.0, and the format version 2 adoption vote in 0.12.0. Entries that also contain Java changes are kept intact. Generated-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Following the review decision, this PR only removes the spec changes from the Java release notes. The format versioning tables and changes since adoption sections in the specs, the REST Catalog spec page and the Releases menu changes are reverted. Generated-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the Spec section and the spec-only Open API / REST entries from the 1.12.0 Java release notes, which were added on main after this change was started. The only remaining entry, the REST client path encoding fix, contains Java changes only, so it is moved to the Core section and the Open API / REST section is removed. Generated-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
51234f4 to
2a5e40b
Compare
|
Could someone double check the PR? |
|
taking another look! 😄 |
apache#14045, apache#13619, and apache#10603 also change Java behavior (PositionDelete deprecation, REST 503 handling, OAuth2 endpoint warning), so restore them with wording that describes the Java change. Link the 1.1.0 Puffin statistics entry to the Java implementation (apache#4741) instead of the spec-only apache#4945. Generated-by: GitHub Copilot (Claude Opus 5.5) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I pushed 05d1c59 with a few small fixes to address my nit comments:
- Restored #14045, #13619, and #10603. They're spec PRs but also change java behavior (
PositionDeletedeprecation, REST 503 handling, oauth endpoint warning), so they follow the same rule as the RCK and Open API jar entries. - Pointed the 1.1.0 Puffin statistics entry at the java PR (#4741) instead of the spec-only #4945.
Let me know what you think of these changes, and please feel free to revert if you dont think they're necessary.
Could you also update the PR title and description to match the current state? Maybe "Docs: Remove spec changes from Java release notes"?
| The 1.11.0 release contains bug fixes and new features. For full release notes visit [Github](https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.11.0) | ||
|
|
||
| * Deprecation / End of Support | ||
| - Spec: Deprecate Position delete files with row data ([\#14045](https://github.com/apache/iceberg/pull/14045)) |
There was a problem hiding this comment.
nit: i think we can keep this one since its also a PR to deprecate methods in Core
| - REST: Add row lineage fields ([\#13010](https://github.com/apache/iceberg/pull/13010)) | ||
| - REST: Add encryption keys ([\#12987](https://github.com/apache/iceberg/pull/12987)) | ||
| - REST: remove update to enable row lineage as it is always on for V3 table ([\#12986](https://github.com/apache/iceberg/pull/12986)) | ||
| - REST: mark 503 as non retryable ([\#13619](https://github.com/apache/iceberg/pull/13619)) |
There was a problem hiding this comment.
nit: same as the other, worth keeping the core changes in here
| - Turn off the stats gathering when iceberg.hive.keep.stats is false ([\#10148](https://github.com/apache/iceberg/pull/10148)) | ||
| * Specs | ||
| - OpenAPI: TableRequirements should use union of subclasses ([\#10434](https://github.com/apache/iceberg/pull/10434)) | ||
| - OpenAPI: Deprecate oauth/tokens endpoint ([\#10603](https://github.com/apache/iceberg/pull/10603)) |
There was a problem hiding this comment.
nit: same as the others, worth keeping the entry for behavior change
|
Merged to main. |



Spec changes are adopted by community vote and are independent of the Java releases, so listing them in the Java release notes is misleading. As agreed on the community sync, this PR removes the spec changes from the Java release notes, including the past releases, and don't add them anywhere else.
Entries for pull requests that also change the Java implementation are kept, for example the REST Compatibility Kit and the Open API runtime Jar changes. No other files are changed.
AI Disclosure