Skip to content

Flink: Preserve RowKind in DynamicIcebergSink's DataConverter #18101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvary merged 1 commit into from
Sep 14, 2026
Merged

Flink: Preserve RowKind in DynamicIcebergSink's DataConverter #18101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DataConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class RowDataConverter implements DataConverter {
@Override
public RowData convert(Object object) {
RowData sourceData = (RowData) object;
GenericRowData targetData = new GenericRowData(fieldGetters.length);
GenericRowData targetData = new GenericRowData(sourceData.getRowKind(), fieldGetters.length);
for (int i = 0; i < fieldGetters.length; i++) {
Object value = fieldGetters[i].getFieldOrNull(sourceData);
targetData.setField(i, dataConverters[i].convert(value));
Expand Down
9 changes: 9 additions & 0 deletions .../v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestRowDataConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.apache.flink.table.data.RowData;
import org.apache.flink.table.data.StringData;
import org.apache.flink.table.data.TimestampData;
import org.apache.flink.types.RowKind;
import org.apache.iceberg.Schema;
import org.apache.iceberg.flink.DataGenerator;
import org.apache.iceberg.flink.DataGenerators;
Expand Down Expand Up @@ -76,6 +77,14 @@ void testAddColumn() {
.isEqualTo(GenericRowData.of(1, StringData.fromString("a"), null));
}

@Test
void testPreservesRowKind() {
RowData deleteRow = SimpleDataUtil.createRowData(1, "a");
deleteRow.setRowKind(RowKind.DELETE);

assertThat(convert(deleteRow, SCHEMA, SCHEMA2).getRowKind()).isEqualTo(RowKind.DELETE);
}

@Test
void testAddRequiredColumn() {
Schema currentSchema = new Schema(Types.NestedField.optional(1, "id", Types.IntegerType.get()));
Expand Down
Loading