Arrow: Fix int96 timestamp offset in arrow dictionary decode

[sungwy]

Issue: #13485

This PR fixes the packed dictionary INT96 timestamp decode path in the VectorizedParquetDefinitionLevelReader to write using byte offsets rather than row indexes.

The unit test constructs a dictionary with expected values and verifies that the decoded Arrow buffer contains the expected timestamp values, and verifies that writing multiple rows of values did not corrupt the data as a result of the values being written into the wrong offsets.

The fix is the same as the earlier proposed change discussed in #13486 , and mirrors the offset handling used by other readers in the same class:

iceberg/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java

Line 302 in 8e7ab3c

.setLong((long) idx * typeWidth, dict.decodeToLong(reader.readInteger()));

Disclosure:

• AI-assisted analysis and test drafting were used while investigating this issue. The final code and test were reviewed, edited, and validated manually. Refer: https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions

[Copilot]

Pull request overview

Fixes incorrect INT96 timestamp decoding for Parquet dictionary-encoded packed data in Iceberg’s Arrow vectorized reader by writing to Arrow buffers using byte offsets (instead of value indices), preventing buffer corruption and wrong timestamps.

Changes:

• Correct TimestampInt96Reader.nextDictEncodedVal (PACKED mode) to use (long) idx * typeWidth when calling setLong.
• Add a unit test that reproduces the corruption scenario and verifies correct decoded timestamps across multiple rows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java	Fixes packed dictionary INT96 decode to write to Arrow buffers using byte offsets, matching other readers and preventing data corruption.
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/parquet/TestVectorizedParquetDefinitionLevelReader.java	Adds a regression test ensuring packed dictionary INT96 decoding writes correct per-row values without overwriting adjacent entries.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[nastra]

this makes sense to me

[sungwy]

Thanks for the review @nastra - I'll leave it open for a few more days for additional review and merge

[manuzhang]

@sungwy Please double check the commit message has the module prefix like the PR title when merging.

[kevinjqliu]

LGTM! #16459 called out both VectorizedParquetDefinitionLevelReader and VectorizedDictionaryEncodedParquetValuesReader
both now has the same fix

iceberg/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java

Lines 105 to 114 in f12e0cf

	class TimestampInt96DictEncodedReader extends BaseDictEncodedReader {
	@Override
	protected void nextVal(
	FieldVector vector, Dictionary dict, int idx, int currentVal, int typeWidth) {
	ByteBuffer buffer =
	dict.decodeToBinary(currentVal).toByteBuffer().order(ByteOrder.LITTLE_ENDIAN);
	long timestampInt96 = ParquetUtil.extractTimestampInt96(buffer);
	vector.getDataBuffer().setLong((long) idx * typeWidth, timestampInt96);
	}
	}