Repository navigation
Build: Use major.minor versions in runtime-deps baselines - #16233
Conversation
|
i was surprised by the drift in runtime-deps.txt, @RussellSpitzer wydt about this pattern to autoupdate for dependabot? |
|
@kevinjqliu Ryan and I discussed this in the previous work. Rather than letting dependapot automatically change the deps (or raise the change) we just decided to ignore patch updates. I still record them though so it may make sense to remove them |
|
I think I would vote that we just drop the patch's from the dependency text to avoid the churn there. |
430ab99 to
9bbf0b9
Compare
d9426bd to
7ce9c66
Compare
i like that more, made the change |
7ce9c66 to
5bd85d8
Compare
5bd85d8 to
2b99aa6
Compare
|
Looks good to me but we'll have to do a fast rebase and merge to get this in, @kevinjqliu as soon as you rebase at tests pass I think you should merge |
|
Ran Thanks for the review |
Summary
This PR changes
checkRuntimeDepsto store onlymajor.minorinruntime-deps.txtfiles.Previously,
runtime-deps.txtstored fullmajor.minor.patchversions butcheckRuntimeDepsonly flagged mismatches at themajor.minorlevel. This allowed Dependabot patch bumps (e.g.5.6.0 → 5.6.1) to pass CI without updating the baseline, but over time the baselines drifted from the actual resolved dependencies, causing PRs like #16204 to merge with stale baselines.By storing only
major.minorin the baseline, bothgenerateRuntimeDepsandcheckRuntimeDepsnow operate on the same coordinates. Patch bumps produce identical entries so Dependabot PRs pass freely, while major/minor changes, added deps, and removed deps still fail the check.Testing