Skip to content

Core: Replace deprecated CloseableHttpClient.execute - #16149

Merged
pvary merged 1 commit into
apache:mainfrom
ebyhr:ebi/http-client
May 25, 2026
Merged

pvary merged 1 commit into
apache:mainfrom
ebyhr:ebi/http-client

Conversation

@ebyhr

@ebyhr ebyhr commented Apr 28, 2026

Copy link
Copy Markdown
Member

Replaces the deprecated method usage execute(ClassicHttpRequest, HttpContext) with execute(ClassicHttpRequest, HttpClientResponseHandler).

I recommend reviewing this RP with the hiding whitespace option.

@github-actions github-actions Bot added the core label Apr 28, 2026

@gaborkaszab gaborkaszab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ebyhr !
I think this makes sense. Just some minor comments.

Comment thread core/src/main/java/org/apache/iceberg/rest/HTTPClient.java
Comment thread core/src/main/java/org/apache/iceberg/rest/HTTPClient.java
@ebyhr
ebyhr force-pushed the ebi/http-client branch from 38a3cfd to dd5d404 Compare April 30, 2026 05:32
Comment thread core/src/main/java/org/apache/iceberg/rest/HTTPClient.java

@gaborkaszab gaborkaszab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks @ebyhr !

@gaborkaszab

Copy link
Copy Markdown
Contributor

Maybe @pvary, would you mind taking a look?

@ebyhr

ebyhr commented May 25, 2026

Copy link
Copy Markdown
Member Author

@pvary Can we merge this PR?

@pvary
pvary merged commit d3cb9e3 into apache:main May 25, 2026
36 checks passed
@pvary

pvary commented May 25, 2026

Copy link
Copy Markdown
Contributor

Merged to main.
Thanks @ebyhr for the PR and @gaborkaszab for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants