Skip to content

Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 7 commits into from
Oct 13, 2020
Merged

Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory #1579

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c10990
Fix off by one error in TestHiveIcebergFilterFactory#testDateType so …
kbendick Oct 11, 2020
50f29cd
Use Date.valueOf instead of the confusing 2015-11-13 with start of da…
kbendick Oct 11, 2020
02ea287
Use the dateString as a named parameter, so that hopefully these test…
kbendick Oct 11, 2020
5215096
Fix unused import error
kbendick Oct 11, 2020
0a42de4
remove the named date string
kbendick Oct 11, 2020
91637ff
Update daysFromDate function
kbendick Oct 12, 2020
62c083b
Revert changes to unit tests as we've updated the HiveIcebergFilterFa…
kbendick Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergFilterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.math.BigDecimal;
import java.sql.Date;
import java.sql.Timestamp;
import java.time.Instant;
import java.util.List;
import java.util.stream.Collectors;
import org.apache.hadoop.hive.ql.io.sarg.ExpressionTree;
Expand Down Expand Up @@ -169,7 +170,7 @@ private static BigDecimal hiveDecimalToBigDecimal(HiveDecimalWritable hiveDecima
}

private static int daysFromDate(Date date) {
return DateTimeUtil.daysFromDate(date.toLocalDate());
return DateTimeUtil.daysFromInstant(Instant.ofEpochMilli(date.getTime()));
}

private static int daysFromTimestamp(Timestamp timestamp) {
Expand Down