Repository navigation
Flink: Fix non-deterministic operator UIDs in DynamicIcebergSink - #15687
Merged
Merged
Conversation
The pre-commit topology operator UID included a random UUID (sinkId), which changed on every sink instantiation. This prevented Flink from restoring state from checkpoints/savepoints because operator UIDs didn't match across full redeploys. This did not affect simple failures / restarts because the JobGraph is not re-generated then. Use a fixed suffix for the UID, consistent with the other operators (generator, updater, sink) which already use deterministic UIDs. The sinkId is still used in the committer for file separation. I deliberately did not change the UID syntax. Despite the bug, users will still be able to restore state, e.g. via Flink's `allowNonRestoredState`, but we must keep the stateful operators UUIds like the committer consistent.
pvary
approved these changes
Mar 20, 2026
Contributor
|
Merged to main. |
Contributor
Author
|
Thanks @pvary! |
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Mar 20, 2026
huaxingao
pushed a commit
that referenced
this pull request
Mar 20, 2026
1 of 3 tasks
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Mar 23, 2026
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Mar 23, 2026
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit topology operator UID included a random UUID (sinkId), which changed on every sink instantiation. This prevented Flink from restoring state from checkpoints/savepoints because operator UIDs didn't match across full redeploys. This did not affect simple failures / restarts because the JobGraph is not re-generated then.
Use a fixed suffix for the UID, consistent with the other operators (generator, updater, sink) which already use deterministic UIDs. The sinkId is still used in the committer for file separation.
I deliberately did not change the UID syntax. Despite the bug, users will still be able to restore state, e.g. via Flink's
allowNonRestoredState, but we must keep the stateful operators UUIds like the committer consistent.