Skip to content

REST: Fix serde of tasks with multiple deletes - #14573

Merged
singhpk234 merged 3 commits into
apache:mainfrom
singhpk234:fix/tableScanParser
Nov 13, 2025
Merged

singhpk234 merged 3 commits into
apache:mainfrom
singhpk234:fix/tableScanParser

Conversation

@singhpk234

Copy link
Copy Markdown
Contributor

About the change

Extracts the another bug fix extract from #13400 this was discovered when adding E2E test, essentially when calculating the delete file index this should be scoped in per file scan task where on collecting the deletes we reverse lookup to find its index and it should cleared, there is an E2E test for this in #13400

Testing

Adding UT for this

@github-actions github-actions Bot added the core label Nov 12, 2025
@singhpk234 singhpk234 added this to the Iceberg 1.10.1 milestone Nov 12, 2025
@singhpk234

Copy link
Copy Markdown
Contributor Author

Adding this to milestone 1.10.1 for now please feel free to remove if this can wait.

Comment thread core/src/main/java/org/apache/iceberg/rest/TableScanResponseParser.java Outdated

@nastra nastra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments

@singhpk234
singhpk234 merged commit 571b696 into apache:main Nov 13, 2025
44 checks passed
@singhpk234

Copy link
Copy Markdown
Contributor Author

Thanks @huaxingao @ebyhr @nastra @amogh-jahagirdar for reviews !

sfc-gh-prsingh added a commit to singhpk234/iceberg that referenced this pull request Nov 13, 2025
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
nastra pushed a commit that referenced this pull request Nov 13, 2025
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
thomaschow pushed a commit to thomaschow/iceberg that referenced this pull request Jan 19, 2026
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants