Repository navigation
Spark: [3/N] Support sending referenced-by to all endpoints #13979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
singhpk234
wants to merge
11
commits into
apache:main
Choose a base branch
from
singhpk234:feature/ref-imp-referenced-by
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,519
−12
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7d5b8a8
Spark: Send the referenced-by view chain through SparkCatalog
sfc-gh-prsingh c0a391f
Spark: Move referenced-by context to Spark 4.2
sfc-gh-prsingh 759a96a
Spark: Fix ViewUtil Scala import grouping
sfc-gh-prsingh 8eeaffa
Spark 4.2: Implement contextual loadTable in TestSparkCatalog
sfc-gh-prsingh 48024a9
Spark 4.2: Restore explicit referenced-by view resolution
sfc-gh-prsingh 55bfb19
Core, Spark: Address referenced-by review feedback
sfc-gh-prsingh 3dc7bd8
Spark 4.2: Gate referenced-by view resolution
sfc-gh-prsingh 0311044
Spark 4.2: Use resolved view identity for referenced-by
sfc-gh-prsingh 464f642
Spark 4.2: Address referenced-by review feedback
sfc-gh-prsingh 187c990
Spark 4.2: Resolve referenced-by views in a dedicated rule
sfc-gh-prsingh 3cc4e49
Core, Spark 4.2: Bound referenced-by view depth and canonicalize cont…
sfc-gh-prsingh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...sions/src/main/scala/org/apache/spark/sql/catalyst/analysis/LoadContextTableCatalog.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.spark.sql.catalyst.analysis | ||
|
|
||
| import org.apache.iceberg.catalog.LoadContext | ||
| import org.apache.iceberg.spark.SparkSupportsLoadContext | ||
| import org.apache.spark.sql.connector.catalog.Identifier | ||
| import org.apache.spark.sql.connector.catalog.Table | ||
| import org.apache.spark.sql.connector.catalog.TableCatalog | ||
| import org.apache.spark.sql.connector.catalog.TableChange | ||
| import org.apache.spark.sql.util.CaseInsensitiveStringMap | ||
|
|
||
| /** | ||
| * Catalog for a table read through a view, so that reloads keep the view chain. Spark's table | ||
| * version refresh before execution reloads tables by identifier only, using the relation's | ||
| * catalog. Only read operations are supported. | ||
| */ | ||
| private[analysis] case class LoadContextTableCatalog( | ||
| delegate: TableCatalog with SparkSupportsLoadContext, | ||
| context: LoadContext) | ||
| extends TableCatalog { | ||
|
|
||
| override def name(): String = delegate.name() | ||
|
|
||
| override def initialize(name: String, options: CaseInsensitiveStringMap): Unit = {} | ||
|
|
||
| override def loadTable(ident: Identifier): Table = delegate.loadTable(ident, context) | ||
|
|
||
| override def invalidateTable(ident: Identifier): Unit = delegate.invalidateTable(ident) | ||
|
|
||
| override def listTables(namespace: Array[String]): Array[Identifier] = | ||
| delegate.listTables(namespace) | ||
|
|
||
| override def alterTable(ident: Identifier, changes: TableChange*): Table = | ||
| throw new UnsupportedOperationException(s"Cannot alter table $ident through a view relation") | ||
|
|
||
| override def dropTable(ident: Identifier): Boolean = | ||
| throw new UnsupportedOperationException(s"Cannot drop table $ident through a view relation") | ||
|
|
||
| override def renameTable(oldIdent: Identifier, newIdent: Identifier): Unit = | ||
| throw new UnsupportedOperationException( | ||
| s"Cannot rename table $oldIdent through a view relation") | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.