Skip to content

Docs: Fix style of row-level deletes in spec - #13851

Merged
RussellSpitzer merged 1 commit into
apache:mainfrom
JeonDaehong:issue_13813
Sep 11, 2025
Merged

RussellSpitzer merged 1 commit into
apache:mainfrom
JeonDaehong:issue_13813

Conversation

@JeonDaehong

@JeonDaehong JeonDaehong commented Aug 18, 2025 •

Copy link
Copy Markdown
Contributor

Fix Row-level Deletes Rendering in Spec #13813

This PR fixes the rendering issue of row-level deletes in the Apache Iceberg specification.

  • Ensures that Position deletes and Equality deletes are correctly displayed as bulleted list items.
  • Removes duplicate entries and adds necessary line breaks for proper Markdown rendering.
  • Verified local build to confirm that the spec renders correctly at Row-level Deletes.
image

Closes #13813

@github-actions github-actions Bot added the Specification Issues that may introduce spec changes. label Aug 18, 2025
@JeonDaehong

Copy link
Copy Markdown
Contributor Author

@manuzhang
I have created and submitted the PR.
I would appreciate it if you could review it. :D

@JeonDaehong JeonDaehong changed the title [#13813] Row-level-deletes in spec is not rendered as bulleted list Row-level-deletes in spec is not rendered as bulleted list #13813 Aug 18, 2025
@ebyhr

ebyhr commented Aug 18, 2025

Copy link
Copy Markdown
Member

Note that there is an existing PR: #13816

@ebyhr ebyhr left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the generated page. I recommend attaching screenshots to PR description from next time so that reviewers can easily understand the changes.

Screenshot 2025-08-18 at 21 17 41

Row-level-deletes in spec is not rendered as bulleted list #13813

You can change the PR title to "Docs: Fix style of row-level deletes in spec" or something.

@JeonDaehong JeonDaehong changed the title Row-level-deletes in spec is not rendered as bulleted list #13813 Docs: Fix style of row-level deletes in spec Aug 18, 2025
@JeonDaehong

Copy link
Copy Markdown
Contributor Author

@RussellSpitzer @ebyhr

I heard about this through you.

I had thought that leaving a comment first meant the issue would be assigned, but I didn’t realize that submitting a PR takes precedence.

Thank you very much for kindly clarifying this in your comment. :D
I’ll look for another issue where I can make a meaningful contribution !!!

@JeonDaehong

Copy link
Copy Markdown
Contributor Author

@ebyhr @RussellSpitzer

It has been over 10 days without any further updates on the previous PR. Would it be okay if I continue working on this issue and submit a fix?

@JeonDaehong

Copy link
Copy Markdown
Contributor Author

@ebyhr @RussellSpitzer

It looks like the PR opened by someone else has been closed. Would it be okay if I continue the work in this PR?

@RussellSpitzer
RussellSpitzer merged commit 4e154bd into apache:main Sep 11, 2025
@RussellSpitzer

Copy link
Copy Markdown
Member

Thanks @JeonDaehong for the PR and your patience! Thanks @ebyhr for review and helping with renders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specification Issues that may introduce spec changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Row-level-deletes in spec is not rendered as bulleted list

3 participants