Repository navigation
Spark 3.4: Migrate source and spark tests - #12998
Merged
Merged
Conversation
nastra
reviewed
May 7, 2025
| assertThat(actual) | ||
| .singleElement() | ||
| .satisfies( | ||
| row -> { |
Contributor
Author
There was a problem hiding this comment.
Thanks for checking this, let me update this.
nastra
reviewed
May 7, 2025
| assertThat(actual) | ||
| .singleElement() | ||
| .satisfies( | ||
| row -> { |
Contributor
Author
There was a problem hiding this comment.
let me update this as well.
nastra
approved these changes
May 7, 2025
nastra
left a comment
nastra
left a comment
Contributor
There was a problem hiding this comment.
LGTM with two nits, thanks @tomtongue
Contributor
Author
|
@nastra Thanks for the review!! |
anuragmantri
added a commit
to anuragmantri/iceberg
that referenced
this pull request
Jul 25, 2025
…pache#1588) Co-authored-by: Tom Tanaka <43331405+tomtongue@users.noreply.github.com>
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160
This PR migrates the following Spark 3.4 tests in the
sparkandspark.sourcepackages to JUnit 5 with AssertJ:spark:TestFileRewriteCoordinatorTestSparkCatalogOperationsTestSparkWriteConfTestSparkCachedTableCatalogspark.source:TestDataSourceOptionsTestIcebergSourceTablesBaseTestIcebergSourceHadoopTablesTestIcebergSourceHiveTablesTestMetadataTableReadableMetricsTestMetadataTablesWithPartitionEvolutionAnd, additiona one such as
TestMigrateTableActionwhich is only left in theactionspackage.