Repository navigation
Core: Increase wait time of flaky test - #12714
Merged
Merged
Conversation
Contributor
|
@manuzhang an alternative to this is just to remove the Awaitility and let the concurrency just run naturally. This reduces the overall test time from ~60s to ~10s for me. I'm not sure this gating is really helping with validation of concurrency. Thoughts @nastra? |
Member
Author
@danielcweeks You don't wait for it to finish? |
Member
Author
|
@nastra can you take a look? I'm seeing this flaky test quite often now. |
nastra
reviewed
Apr 28, 2025
| Awaitility.await() | ||
| .pollInterval(Duration.ofMillis(10)) | ||
| .atMost(Duration.ofSeconds(10)) | ||
| .atMost(Duration.ofSeconds(60)) |
Contributor
There was a problem hiding this comment.
I'm not convinced that this will actually help but I'm ok merging this and trying it out. If that doesn't help, then we should consider refactoring the test to avoid flakiness
nastra
approved these changes
Apr 28, 2025
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.