Repository navigation
Bump versions in {LICENSE,NOTICE} - #12337
Merged
Merged
Conversation
Contributor
|
is this something we should be doing once before doing an actual release (and maybe add this type of step to be done when doing the release)? Otherwise we'd have to update those places whenever dependencies change, which seems like a lot of overhead/work |
hussein-awala
approved these changes
Feb 19, 2025
Contributor
Author
|
@nastra I think ideally when we also update the dependency itself, at least that's what @jbonofre suggested here #12209 (comment). This makes it also easier to cherry-pick things back to older branches. |
nastra
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @jbonofre for the ping :)