Skip to content

Docs: Add documentation for Rate limiting in Spark Structured Streaming - #12217

Merged
RussellSpitzer merged 3 commits into
apache:mainfrom
singhpk234:pull_8044
Feb 19, 2025
Merged

RussellSpitzer merged 3 commits into
apache:mainfrom
singhpk234:pull_8044

Conversation

@singhpk234

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the docs label Feb 10, 2025
@singhpk234

Copy link
Copy Markdown
Contributor Author

cc @RussellSpitzer

Comment thread docs/docs/spark-configuration.md Outdated
@wypoon

wypoon commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

I agree that it would be good to add this to the documentation!

Comment thread docs/docs/spark-configuration.md Outdated
| batch-size | As per table property | Overrides this table's read.parquet.vectorization.batch-size |
| stream-from-timestamp | (none) | A timestamp in milliseconds to stream from; if before the oldest known ancestor snapshot, the oldest will be used |
| streaming-max-files-per-micro-batch | INT_MAX | Maximum number of files per microbatch |
| streaming-max-rows-per-micro-batch | INT_MAX | Maximum number of rows per microbatch. This number should be greater than the number of records in any data file in the table. The smallest unit that will be streamed is a single file, so if a data file contains more records than this limit, the stream will get stuck at this file.|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we try to keep these descriptions small. I think you can add a * or note if you have more info you want in here, especially since it seems like we are just describing a bug

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack !
Here is what it looks like now, please let me know your thoughts
Screenshot 2025-02-19 at 10 51 59 AM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes sense to add the caveat as a Note or Warning.

@RussellSpitzer
RussellSpitzer merged commit 25e7897 into apache:main Feb 19, 2025
@RussellSpitzer

Copy link
Copy Markdown
Member

Thanks @singhpk234 and @wypoon for reviewing!

@singhpk234

Copy link
Copy Markdown
Contributor Author

Thanks @RussellSpitzer and @wypoon for the review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants