You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
View's VersionLog uses wrong timestamp if ViewVersions are reused聽#12809
Note that the last and first entries have the same timestamp, namely the timestamp of the initial ViewVersion creation.
I believe this is undesired in a history, where we are interested when a certain change became active. It makes sense to use the exact timestamp of the ViewVersion if it was added in the same set of changes, but re-enabling a previously used view version (maybe years ago) should not add a history for this past timestamp.
I agree this is a bug but i'm not sure about the fix in the rust lib. Maybe I haven't looked into this enough but the time of the creation of the metadata object seems wrong? Shouldn't it be the commit time? If that's just what we are doing in any case then I guess it's fine.
Activity
RussellSpitzer commentedon Apr 16, 2025
I agree this is a bug but i'm not sure about the fix in the rust lib. Maybe I haven't looked into this enough but the time of the creation of the metadata object seems wrong? Shouldn't it be the commit time? If that's just what we are doing in any case then I guess it's fine.