ci: split lint checks and slim clippy - #2771
Merged
Merged
Conversation
blackmwk
approved these changes
Jul 6, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @abnobdoss for this pr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
checkjob split from discussion Streamlining CI: reducing job count and GHA cache pressure #2753.What changes are included in this PR?
Splits the old
checkjob (ubuntu + macos) into two ubuntu jobs:lint: the non-compiling checks (license header, toml format, cargo fmt, Cargo.lock, cargo-machete, typos). The standalone Typos workflow is folded in, and taplo and cargo-machete come as prebuilt binaries.clippy:make check-clippyonly.As suggested in #2753, the heavier jobs now have
needs: lint, so a fmt or typo mistake fails fast without spinning up builds. The tradeoff is that a lint failure blocks all downstream jobs.This also removes the macOS clippy run. Nothing in the repo is gated on
target_os, so clippy output is identical across platforms, and macOS compile coverage stays in the build jobs. The macOScheckjob was CI's slowest at 10 to 12 minutes.Are these changes tested?
CI-only change, exercised by this PR's own CI run.