[shubham-tomar]

I am using Nessie as a catalog, while creating table i was getting below error

Failed to create table: failed to create table: WebApplicationException: HTTP 400 Bad Request

When i checked nessie logs, i found this error

nessie  | Caused by: com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `org.projectnessie.catalog.formats.iceberg.rest.ImmutableIcebergCreateTableRequest`, problem: Cannot build IcebergCreateTableRequest, some of required attributes are not set [stageCreate]

The root cause is:
In the Go library's struct definition, StageCreate is marked as optional with omitempty
When false is set as the value, the JSON marshaler sees it as the zero value for bool and due to omitempty, it omits the field entirely from the JSON
However, the Nessie REST API requires this field to be explicitly set, even if it's false

This small change fixes the issue

[snazy]

The Iceberg REST spec is ambiguous there.
The behaviors for stage-create == true and == false are defined - but no default value/behavior is defined - and the property is optional.
To me that's an issue in the Iceberg REST spec surfaced the Go implementation

[zeroshade]

@snazy Do you know if any other REST implementations have an issue with providing stage-create: false instead of leaving it out?

[snazy]

Do you know if any other REST implementations have an issue with providing stage-create: false instead of leaving it out?

IDK - but it would surprise me if not, because, as I mentioned, a default value isn't defined, so impls would have to guess (wrong)

[shubham-tomar]

Hi @zeroshade, i have added RenameTable Fix too as discussed

[zeroshade]

@shubham-tomar you forgot to update the unit tests with the changed field names for RenameTable 😄

[shubham-tomar]

My Bad, updated the PR