refactor(table)!: name path-based data file additions explicitly

catalog/rest/rest_integration_test.go

@@ -385,7 +385,7 @@ func (s *RestIntegrationSuite) TestWriteCommitTable() {
 	defer mustFS(s.T(), tbl).Remove(s.ctx, pqfile)
 
 	txn := tbl.NewTransaction()
-	s.Require().NoError(txn.AddFiles(s.ctx, []string{pqfile}, nil, false))
+	s.Require().NoError(txn.AddDataFilesByPath(s.ctx, []string{pqfile}, nil, false))
 	updated, err := txn.Commit(s.ctx)
 	s.Require().NoError(err)
 
@@ -465,10 +465,10 @@ func (s *RestIntegrationSuite) TestMultiTableCommit() {
 
 	// Build transactions that add data files to each table.
 	tx1 := tbl1.NewTransaction()
-	s.Require().NoError(tx1.AddFiles(s.ctx, []string{pq1}, nil, false))
+	s.Require().NoError(tx1.AddDataFilesByPath(s.ctx, []string{pq1}, nil, false))
 
 	tx2 := tbl2.NewTransaction()
-	s.Require().NoError(tx2.AddFiles(s.ctx, []string{pq2}, nil, false))
+	s.Require().NoError(tx2.AddDataFilesByPath(s.ctx, []string{pq2}, nil, false))
 
 	// Commit both atomically via MultiTableTransaction.
 	mtx, err := catalog.NewMultiTableTransaction(s.cat)

catalog/rest/scan_planning_integration_test.go

@@ -268,7 +268,7 @@ func (s *RestIntegrationSuite) createScanPlanningTable(cat *rest.Catalog, ident
 	s.T().Cleanup(func() { s.Require().NoError(mustFS(s.T(), tbl).Remove(s.ctx, dataPath)) })
 
 	txn := tbl.NewTransaction()
-	s.Require().NoError(txn.AddFiles(s.ctx, []string{dataPath}, nil, false))
+	s.Require().NoError(txn.AddDataFilesByPath(s.ctx, []string{dataPath}, nil, false))
 	updated, err := txn.Commit(s.ctx)
 	s.Require().NoError(err)
 	s.Require().NotNil(updated.CurrentSnapshot())

catalog/sql/sql_integration_test.go

@@ -297,7 +297,7 @@ func (s *SQLIntegrationSuite) TestWriteCommitTable() {
 	}(fs, pqfile)
 
 	txn := tbl.NewTransaction()
-	s.Require().NoError(txn.AddFiles(s.ctx, []string{pqfile}, nil, false))
+	s.Require().NoError(txn.AddDataFilesByPath(s.ctx, []string{pqfile}, nil, false))
 	updated, err := txn.Commit(s.ctx)
 	s.Require().NoError(err)
 

catalog/sql/sql_test.go

@@ -2760,7 +2760,7 @@ func (s *SqliteCatalogTestSuite) TestCommitTable() {
 		s.EqualValues(0, tbl.Metadata().CurrentSchema().ID)
 
 		tx := tbl.NewTransaction()
-		s.Require().NoError(tx.AddFiles(ctx, []string{pqfile}, nil, false))
+		s.Require().NoError(tx.AddDataFilesByPath(ctx, []string{pqfile}, nil, false))
 		updated, err := tx.Commit(ctx)
 		s.Require().NoError(err)
 

table/addfiles_merge_regression_test.go

@@ -17,14 +17,14 @@
 
 package table_test
 
-// Regression test for: AddFiles() ignoring commit.manifest-merge.enabled.
+// Regression test for: AddDataFilesByPath() ignoring commit.manifest-merge.enabled.
 //
-// Root cause: transaction.go hardcoded .fastAppend() in AddFiles(), bypassing
+// Root cause: transaction.go hardcoded .fastAppend() in AddDataFilesByPath(), bypassing
 // appendSnapshotProducer() which reads ManifestMergeEnabledKey.
 //
 // Java reference: BaseTable.newAppend() always uses MergeAppend (merge default=true).
 // AddDataFiles() and Append() in Go both correctly call appendSnapshotProducer().
-// Only AddFiles() was missing the call.
+// Only AddDataFilesByPath() was missing the call.
 //
 // Fix: change line 780 in transaction.go from:
 //
@@ -71,10 +71,10 @@ func (c *mergeCatalog) CommitTable(_ context.Context, _ table.Identifier, _ []ta
 	return meta, "", nil
 }
 
-// TestAddFilesRespectsMergeEnabled verifies that AddFiles() respects the
+// TestAddFilesRespectsMergeEnabled verifies that AddDataFilesByPath() respects the
 // commit.manifest-merge.enabled table property.
 //
-// Before fix: 3 sequential AddFiles() commits produce 3 manifests because
+// Before fix: 3 sequential AddDataFilesByPath() commits produce 3 manifests because
 // fastAppend() is hardcoded and the merge property is ignored.
 //
 // After fix: with minCountToMerge=2, the 3rd commit triggers a merge and
@@ -131,16 +131,16 @@ func TestAddFilesRespectsMergeEnabled(t *testing.T) {
 		cat,
 	)
 
-	// Perform 3 separate AddFiles commits — simulating the committer's 1-per-batch pattern.
+	// Perform 3 separate AddDataFilesByPath commits — simulating the committer's 1-per-batch pattern.
 	// minCountToMerge=2 means the 3rd commit should trigger a merge.
 	const numCommits = 3
 	for i := range numCommits {
 		filePath := fmt.Sprintf("%s/data-%d.parquet", dir, i)
 		writeParquet(filePath)
 
 		txn := tbl.NewTransaction()
-		require.NoError(t, txn.AddFiles(ctx, []string{filePath}, nil, false),
-			"AddFiles commit %d failed", i+1)
+		require.NoError(t, txn.AddDataFilesByPath(ctx, []string{filePath}, nil, false),
+			"AddDataFilesByPath commit %d failed", i+1)
 
 		tbl, err = txn.Commit(ctx)
 		require.NoError(t, err, "Commit %d failed", i+1)
@@ -155,8 +155,8 @@ func TestAddFilesRespectsMergeEnabled(t *testing.T) {
 	// After fix: merge fires on commit 3 (accumulated 3 > minCount 2) → 1 merged manifest.
 	// Before fix: 3 manifests (fastAppend carries all forward without merging).
 	assert.Equal(t, 1, len(manifests),
-		"expected 1 merged manifest after %d AddFiles commits with manifest merge enabled "+
+		"expected 1 merged manifest after %d AddDataFilesByPath commits with manifest merge enabled "+
 			"(minCountToMerge=2), got %d manifests — "+
-			"AddFiles() is not respecting commit.manifest-merge.enabled",
+			"AddDataFilesByPath() is not respecting commit.manifest-merge.enabled",
 		numCommits, len(manifests))
 }

table/arrow_utils.go

@@ -1881,7 +1881,7 @@ func filesToDataFiles(ctx context.Context, fileIO iceio.IO, meta *MetadataBuilde
 				}
 			}()
 
-			// Pass 0 so AddFiles does not claim sort_order_id on files
+			// Pass 0 so AddDataFilesByPath does not claim sort_order_id on files
 			// it did not write (#1184). Callers that know the file's
 			// sort layout use FileToDataFile with an explicit id.
 			dataFiles[i] = fileToDataFile(ctx, fileIO, filePath, currentSchema, currentSpec, 0, meta.props)

table/arrow_utils_test.go

@@ -3497,7 +3497,7 @@ func TestGeoTypeParquetRoundTrip(t *testing.T) {
 // stored ARROW:schema, as Java/Spark writers produce. geoarrow-go maps the
 // Parquet GEOMETRY logical type to geoarrow.wkb on read, so the file projects
 // onto a matching geometry column. A binary table column rejects it, both on
-// read and in the FileToDataFile (AddFiles) schema check: geo types are
+// read and in the FileToDataFile (AddDataFilesByPath) schema check: geo types are
 // deliberately not promotable to or from binary (see iceberg.PromoteType and
 // https://github.com/apache/iceberg-go/issues/2193), and the binary subtests
 // assert that rejection.
@@ -3603,7 +3603,7 @@ func TestGeoParquetReadWithoutStoredSchema(t *testing.T) {
 		assert.ErrorContains(t, err, "cannot promote geometry(srid:4326) to binary")
 	})
 
-	t.Run("AddFiles schema check rejects binary column", func(t *testing.T) {
+	t.Run("AddDataFilesByPath schema check rejects binary column", func(t *testing.T) {
 		binarySchema := iceberg.NewSchema(0, iceberg.NestedField{ID: 1, Name: "geom", Type: iceberg.PrimitiveTypes.Binary, Required: false})
 		_, err := table.FileToDataFile(context.Background(), iceio.LocalFS{}, path, binarySchema, *iceberg.UnpartitionedSpec, 0, nil)
 		require.Error(t, err)

table/branch_planning_test.go

@@ -430,7 +430,7 @@ func TestBranchAddDataFilesDuplicateCheckUsesBranchHead(t *testing.T) {
 	})
 }
 
-// AddFiles runs the same check from paths, through its own snapshot lookup.
+// AddDataFilesByPath runs the same check from paths, through its own snapshot lookup.
 func TestBranchAddFilesDuplicateCheckUsesBranchHead(t *testing.T) {
 	t.Run("rejects a file the branch already references", func(t *testing.T) {
 		tbl := seedDivergentBranch(t, newBranchPlanningTable(t, nil))
@@ -439,7 +439,7 @@ func TestBranchAddFilesDuplicateCheckUsesBranchHead(t *testing.T) {
 		txn, err := tbl.NewTransactionOnBranch(branchPlanningRef)
 		require.NoError(t, err)
 
-		err = txn.AddFiles(t.Context(), []string{branchOnly}, nil, false)
+		err = txn.AddDataFilesByPath(t.Context(), []string{branchOnly}, nil, false)
 		require.ErrorContains(t, err, "cannot add files that are already referenced by table")
 		assert.Contains(t, err.Error(), branchOnly)
 	})
@@ -451,7 +451,7 @@ func TestBranchAddFilesDuplicateCheckUsesBranchHead(t *testing.T) {
 		txn, err := tbl.NewTransactionOnBranch(branchPlanningRef)
 		require.NoError(t, err)
 
-		require.NoError(t, txn.AddFiles(t.Context(), []string{mainOnly}, nil, false))
+		require.NoError(t, txn.AddDataFilesByPath(t.Context(), []string{mainOnly}, nil, false))
 		tbl, err = txn.Commit(t.Context())
 		require.NoError(t, err)
 
@@ -602,7 +602,7 @@ func TestBranchRowDeltaResolvesRemovedDeletesOnBranchHead(t *testing.T) {
 	writeParquetFile(t, dataPath, arrowSchema, `[{"id":1},{"id":2},{"id":3},{"id":4},{"id":5}]`)
 
 	txn := tbl.NewTransaction()
-	require.NoError(t, txn.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, txn.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = txn.Commit(t.Context())
 	require.NoError(t, err)
 

table/compaction/analyze_test.go

@@ -113,7 +113,7 @@ func TestAnalyze_SmallFiles(t *testing.T) {
 			fmt.Sprintf(`[{"id": %d, "data": "row-%d"}]`, i+1, i+1))
 
 		tx := tbl.NewTransaction()
-		require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+		require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 		tbl, err = tx.Commit(t.Context())
 		require.NoError(t, err)
 	}
@@ -147,7 +147,7 @@ func TestAnalyze_AllOptimal(t *testing.T) {
 	writeTestParquetFile(t, dataPath, arrowSc, `[{"id": 1, "data": "hello"}]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 

table/compaction/cdc_stress_test.go

@@ -83,7 +83,7 @@ func TestCDCStress(t *testing.T) {
 	seedPath := tbl.Location() + "/data/seed.parquet"
 	writeParquet(t, seedPath, arrowSc, generateRowsJSON(baselineRows))
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{seedPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{seedPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -99,7 +99,7 @@ func TestCDCStress(t *testing.T) {
 			fmt.Sprintf(`[{"id": %d, "data": "cdc-%d"}]`, extraID, cycle))
 
 		tx := tbl.NewTransaction()
-		require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+		require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 		tbl, err = tx.Commit(t.Context())
 		require.NoError(t, err)
 

table/compaction/pos_delete_collect_ext_test.go

@@ -49,7 +49,7 @@ func TestCollectDeadPositionDeletes(t *testing.T) {
 		p := tbl.Location() + fmt.Sprintf("/data/d-%d.parquet", i)
 		writeParquet(t, p, arrowSc, fmt.Sprintf(`[{"id": %d, "data": "r%d"}]`, i+1, i+1))
 		tx := tbl.NewTransaction()
-		require.NoError(t, tx.AddFiles(ctx, []string{p}, nil, false))
+		require.NoError(t, tx.AddDataFilesByPath(ctx, []string{p}, nil, false))
 		tbl, err = tx.Commit(ctx)
 		require.NoError(t, err)
 	}
@@ -160,7 +160,7 @@ func TestDeadPositionDeleteRoundTrip(t *testing.T) {
 		writeParquet(t, dataPaths[i], arrowSc, fmt.Sprintf(`[{"id": %d, "data": "r%d"}]`, i+1, i+1))
 	}
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(ctx, dataPaths, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(ctx, dataPaths, nil, false))
 	tbl, err = tx.Commit(ctx)
 	require.NoError(t, err)
 

table/compaction_file_grain_test.go

@@ -56,7 +56,7 @@ func TestCompactionPreservesSplitFileRows(t *testing.T) {
 					}
 					tx := tbl.NewTransaction()
 					require.NoError(t, tx.SetProperties(iceberg.Properties{table.ReadSplitTargetSizeKey: splitSize}))
-					require.NoError(t, tx.AddFiles(t.Context(), []string{path}, nil, false))
+					require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{path}, nil, false))
 					tbl, err = tx.Commit(t.Context())
 					require.NoError(t, err)
 					scan := tbl.Scan()

table/data_file_meta.go

@@ -293,7 +293,7 @@ func DataFileFromMetadata(args DataFileArgs) (iceberg.DataFile, error) {
 			statsPlan,
 			pathMapping,
 			tblutils.VariantFieldIDsFromSchema(args.Schema),
-			// Metadata-only path: no file is read here, so no arrow schema; AddFiles recomputes variant bounds in fileToDataFile.
+			// Metadata-only path: no file is read here, so no arrow schema; AddDataFilesByPath recomputes variant bounds in fileToDataFile.
 			nil,
 		)
 		if stats == nil {

table/dv_rewrite_test.go

@@ -239,7 +239,7 @@ func TestRewriteFiles_DataSequenceNumberKeepsDVApplicableToReplacement(t *testin
 	oldDataPath := tbl.Location() + "/data/old-data.parquet"
 	writeParquetFile(t, oldDataPath, arrowSc, `[{"id":1,"data":"a"},{"id":2,"data":"b"}]`)
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{oldDataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{oldDataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 

table/equality_delete_commit_test.go

@@ -61,7 +61,7 @@ func TestCommitEqualityDeletesUnpartitioned(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 	assertRowCount(t, tbl, 5)
@@ -190,7 +190,7 @@ func TestCommitEqualityDeletesConcurrentAppendConflict(t *testing.T) {
 		{"id": 3, "data": "c"}
 	]`)
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -205,7 +205,7 @@ func TestCommitEqualityDeletesConcurrentAppendConflict(t *testing.T) {
 	peerPath := tbl.Location() + "/data/peer.parquet"
 	writeParquetFile(t, peerPath, arrowSc, `[{"id": 4, "data": "d"}]`)
 	peerTxn := tbl.NewTransaction()
-	require.NoError(t, peerTxn.AddFiles(t.Context(), []string{peerPath}, nil, false))
+	require.NoError(t, peerTxn.AddDataFilesByPath(t.Context(), []string{peerPath}, nil, false))
 	_, err = peerTxn.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -241,7 +241,7 @@ func TestCommitEqualityDeletesSnapshotIsolationAllowsConcurrentAppend(t *testing
 		{"id": 2, "data": "b"}
 	]`)
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -253,7 +253,7 @@ func TestCommitEqualityDeletesSnapshotIsolationAllowsConcurrentAppend(t *testing
 	peerPath := tbl.Location() + "/data/peer.parquet"
 	writeParquetFile(t, peerPath, arrowSc, `[{"id": 3, "data": "c"}]`)
 	peerTxn := tbl.NewTransaction()
-	require.NoError(t, peerTxn.AddFiles(t.Context(), []string{peerPath}, nil, false))
+	require.NoError(t, peerTxn.AddDataFilesByPath(t.Context(), []string{peerPath}, nil, false))
 	_, err = peerTxn.Commit(t.Context())
 	require.NoError(t, err)
 

table/equality_delete_reader_test.go

@@ -97,7 +97,7 @@ func TestEqualityDeleteReadRoundTrip(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 	assertRowCount(t, tbl, 5)
@@ -197,7 +197,7 @@ func TestEqualityDeleteReadPrunesNonOverlappingDeleteFiles(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(ctx, dataPaths, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(ctx, dataPaths, nil, false))
 	tbl, err = tx.Commit(ctx)
 	require.NoError(t, err)
 
@@ -276,7 +276,7 @@ func TestEqualityDeleteReadResolvesRenamedDataColumnByFieldID(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -400,7 +400,7 @@ func TestEqualityDeleteReadResolvesLiteralDottedColumnName(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err := tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -447,7 +447,7 @@ func TestEqualityDeleteReadRejectsAmbiguousColumns(t *testing.T) {
 	dataPath := tbl.Location() + "/data/data.parquet"
 	writeParquetFile(t, dataPath, arrowSc, `[{"id": 1, "data": "one"}]`)
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -709,7 +709,7 @@ func TestEqualityDeleteMultiColumnKey(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 
@@ -837,7 +837,7 @@ func TestEqualityDeleteNullableFastPathKeys(t *testing.T) {
 				writeParquetFile(t, dataPath, arrowSc, tt.dataJSON)
 
 				tx := tbl.NewTransaction()
-				require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+				require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 				tbl, err = tx.Commit(t.Context())
 				require.NoError(t, err)
 
@@ -928,7 +928,7 @@ func TestEqualityDeleteNullableCompositeFastPathKey(t *testing.T) {
 			writeParquetFile(t, dataPath, arrowSc, tt.dataJSON)
 
 			tx := tbl.NewTransaction()
-			require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+			require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 			tbl, err = tx.Commit(t.Context())
 			require.NoError(t, err)
 

table/equality_delete_writer_test.go

@@ -522,7 +522,7 @@ func TestWriteEqualityDeleteFilesCommitViaRowDelta(t *testing.T) {
 	]`)
 
 	tx := tbl.NewTransaction()
-	require.NoError(t, tx.AddFiles(t.Context(), []string{dataPath}, nil, false))
+	require.NoError(t, tx.AddDataFilesByPath(t.Context(), []string{dataPath}, nil, false))
 	tbl, err = tx.Commit(t.Context())
 	require.NoError(t, err)
 	assertRowCount(t, tbl, 3)

table/internal/parquet_files.go

@@ -537,8 +537,8 @@ type geoColumn struct {
 // Parquet drops the Statistics block (min, max, null count) for GEOMETRY and
 // GEOGRAPHY columns because their sort order is undefined, so these metrics are
 // computed from the Arrow data instead. Geo files imported via
-// DataFileStatsFromMeta alone (e.g. AddFiles) get no geo null counts or bounds,
-// which costs pruning but never gives a wrong answer.
+// DataFileStatsFromMeta alone (e.g. AddDataFilesByPath) get no geo null counts
+// or bounds, which costs pruning but never gives a wrong answer.
 func collectGeoColumns(sc *arrow.Schema, colMapping map[string]int) []geoColumn {
 	var result []geoColumn
 	for i, f := range sc.Fields() {